fix(transfer): 8 behavioral fixes from post-merge bug-hunt#2130
Merged
Conversation
- ResourceExistsException now returns HTTP 409 (per model httpError), not 400 - CreateServer defaults Protocols to ["SFTP"] so DescribeServer never omits it - ImportHostKey derives Type (ssh-ed25519/ecdsa-sha2-nistp*/ssh-rsa) from the key body - DeleteServer now removes the tag entries of every cascaded child resource - UpdateServer ignores the create-only Domain member (update-specific field list) - ListTagsForResource honours MaxResults/NextToken (model has NextToken) - CreateServer folds insert + tag storage into a single write lock - ImportCertificate parses the PEM to populate Serial/NotBeforeDate/NotAfterDate Adds a regression test per fix; conformance stays 71/71 ops, 2756/2756 variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge bug-hunt on the Transfer Family crate (#2129) found 8 real (MED/LOW) behavioral divergences. Round-trip integrity and persistence/concurrency were clean; these are error-code, defaulting, and computed-field fixes.
resource_exists()) — modelhttpError: 409; affects duplicate CreateUser/CreateAccess/ImportSshPublicKey.Protocolsdefaulted to["SFTP"]on create when absent (DescribeServer always returns it; omission -> terraformaws_transfer_serverdrift).Typederived from the key body (ssh-ed25519 / ecdsa-sha2-nistp256|384|521, default ssh-rsa) instead of hardcodedssh-rsa.Domain— added an update-specific field list (Domain is not an UpdateServer input member).Test plan
cargo run -p fakecloud-conformance -- run --services transfer= 71/71 ops, 2756/2756 variants. Audit PASS.cargo clippy --all-targets -- -D warningsclean.No non-code surface change (behavioral fixes; op set/counts unchanged).
Summary by cubic
Fixes eight Transfer behavior mismatches to align with AWS, covering error codes, defaults, computed fields, cascading tag cleanup, update validation, pagination, and a small locking improvement. Adds regression tests; no API changes.
Bug Fixes
Dependencies
x509-cert(withpemfeature) for certificate parsing.Written for commit 21ee835. Summary will update on new commits.