fix(release): publish fakecloud-elasticache after its s3 dependency#2318
Merged
Conversation
fakecloud-elasticache gained a dependency on fakecloud-s3, but the release.yml
publish list still had it in layer-1 (before s3 in layer-4). That made the
Crates publish job fail mid-release ("failed to select a version for the
requirement fakecloud-s3"). Move it to just after fakecloud-s3. Verified the
whole publish order is now topologically valid (every crate's fakecloud-* deps
publish earlier).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fakecloud-elasticachegained a dependency onfakecloud-s3, but therelease.ymlpublish list still ordered it in layer 1 — beforefakecloud-s3(layer 4). During the v0.41.1 release thePublish Cratesjob failed withfailed to select a version for the requirement fakecloud-s3 = "^0.41.1"because s3 hadn't been published yet. (v0.41.1 crates were published out-of-band via a defer-and-retry local publish; this fixes the pipeline so future releases don't hit it.)Moves
publish fakecloud-elasticacheto just afterpublish fakecloud-s3. Verified the entire publish order is now topologically valid — every crate'sfakecloud-*deps publish before it.Test plan
fakecloud-*dependencies appear earlier → 0 violations.Summary by cubic
Reorders the release workflow to publish
fakecloud-elasticacheimmediately afterfakecloud-s3, fixing the dependency order that caused publish failures. The publish list is now topologically valid so everyfakecloud-*dependency is published before its dependents.Written for commit e51c5f5. Summary will update on new commits.