expand semantic index regression coverage

Author: fajarnugraha37

global-template/docgen/test/semantic-index.test.mjs

@@ -3,35 +3,61 @@ import assert from 'node:assert/strict';
 import fs from 'node:fs';
 import os from 'node:os';
 import path from 'node:path';
+import { spawnSync } from 'node:child_process';
+import { fileURLToPath } from 'node:url';
 import { buildInventory } from '../lib/inventory.mjs';
 import { compileContext } from '../lib/context.mjs';
 import { databaseStats, indexRepository } from '../lib/indexer.mjs';
-import { generate } from '../lib/pipeline.mjs';
+import { audit, generate } from '../lib/pipeline.mjs';
 import { projectPaths, readJson, writeJson } from '../lib/core.mjs';
 
+const testDir = path.dirname(fileURLToPath(import.meta.url));
+const cli = path.resolve(testDir, '..', 'bin', 'docgen-v2.mjs');
+
 function fixture() {
   const root = fs.mkdtempSync(path.join(os.tmpdir(), 'docgen-v2-')); const p = projectPaths(root);
   fs.mkdirSync(path.join(root, 'src'), { recursive: true });
   fs.mkdirSync(path.dirname(p.config), { recursive: true });
   writeJson(p.project, { schemaVersion: '2.0', kitVersion: '2.0.0' });
-  writeJson(p.config, { schemaVersion: '2.0', ignore: { binary: { enabled: true, maxTextFileBytes: 1024 * 1024 } }, context: { maxTokens: { default: 4000, generate: 4000 } }, execution: { generationBatchSize: 2 }, audit: { llmEnabled: false } });
+  writeJson(p.config, { schemaVersion: '2.0', projectName: 'Fixture', ignore: { useGitignore: true, useDocgenignore: true, binary: { enabled: true, maxTextFileBytes: 1024 * 1024 } }, context: { maxTokens: { default: 4000, generate: 4000 } }, execution: { generationBatchSize: 2, maxPlannedPages: 30 }, audit: { llmEnabled: false } });
   writeJson(p.state, { schemaVersion: '2.0', kitVersion: '2.0.0', stages: {}, pages: {} });
   return root;
 }
 
+function catalogFixture(root) {
+  const p = projectPaths(root);
+  fs.writeFileSync(path.join(root, 'src', 'Resource.java'), '@Path("/quotes")\nclass Resource { @POST void create() {} }\n');
+  indexRepository(root, { force: true });
+  fs.mkdirSync(p.model, { recursive: true });
+  writeJson(path.join(p.model, 'catalogs.json'), { schemaVersion: '2.0', endpoints: [{ id: 'create-quote', name: 'Create quote', statement: 'Creates a quote.', classification: 'FACT', confidence: 1, method: 'POST', path: '/quotes', evidence: [{ path: 'src/Resource.java', startLine: 1 }] }], messageHandlers: [], externalDependencies: [], dataStores: [], scheduledJobs: [] });
+  writeJson(p.plan, { schemaVersion: '2.0', pages: [{ id: 'endpoint-catalog', title: 'Endpoint Catalog', summary: 'HTTP API reference.', category: 'api', mode: 'reference', type: 'reference', order: 1, audience: ['engineer'], coverageTags: ['endpoint-catalog'], query: 'endpoints', requiredSections: [], relatedPages: [] }] });
+  return p;
+}
+
 test('inventory excludes binary and docgenignore paths', () => {
   const root = fixture();
   fs.writeFileSync(path.join(root, 'src', 'Resource.java'), '@Path("/quotes")\nclass Resource { @GET void get() {} }\n');
   fs.writeFileSync(path.join(root, 'secret.txt'), 'ignore me');
   fs.writeFileSync(path.join(root, 'image.png'), Buffer.from([0x89,0x50,0x4e,0x47,0,1]));
   fs.writeFileSync(path.join(root, '.docgenignore'), 'secret.txt\n');
-  const inv = buildInventory(root, { force: true });
-  assert(inv.files.some((x) => x.path === 'src/Resource.java'));
-  assert(!inv.files.some((x) => x.path === 'secret.txt'));
-  assert(inv.excluded.some((x) => x.path === 'image.png'));
+  const inv = buildInventory(root);
+  assert(inv.files.some((item) => item.path === 'src/Resource.java'));
+  assert(!inv.files.some((item) => item.path === 'secret.txt'));
+  assert(inv.excluded.some((item) => item.path === 'image.png'));
+});
+
+test('non-git inventory respects nested gitignore files', () => {
+  const root = fixture();
+  fs.mkdirSync(path.join(root, 'src', 'generated'), { recursive: true });
+  fs.writeFileSync(path.join(root, 'src', 'generated', '.gitignore'), '*.txt\n');
+  fs.writeFileSync(path.join(root, 'src', 'generated', 'secret.txt'), 'ignored');
+  fs.writeFileSync(path.join(root, 'src', 'generated', 'public.java'), 'class Public {}');
+  const inv = buildInventory(root);
+  assert(!inv.files.some((item) => item.path === 'src/generated/secret.txt'));
+  assert(inv.files.some((item) => item.path === 'src/generated/public.java'));
 });
 
-test('index is incremental and extracts repository facts', () => {
+test('index is incremental and extracts source chunks and facts', () => {
   const root = fixture();
   fs.writeFileSync(path.join(root, 'src', 'Resource.java'), '@Path("/quotes")\nclass Resource { @POST void create() {} }\n');
   const first = indexRepository(root, { force: true });
@@ -41,6 +67,7 @@ test('index is incremental and extracts repository facts', () => {
   assert.equal(second.changedFiles, 0);
   assert.equal(second.unchangedFiles > 0, true);
   assert.equal(stats.facts > 0, true);
+  assert.equal(stats.sourceChunks > 0, true);
 });
 
 test('context compiler stays within configured budget', () => {
@@ -53,17 +80,34 @@ test('context compiler stays within configured budget', () => {
   assert(payload.omissions.facts > 0);
 });
 
-test('reference catalog page is rendered without a provider call', async () => {
-  const root = fixture(); const p = projectPaths(root);
-  fs.writeFileSync(path.join(root, 'src', 'Resource.java'), '@Path("/quotes")\nclass Resource { @POST void create() {} }\n');
-  indexRepository(root, { force: true });
-  fs.mkdirSync(p.model, { recursive: true });
-  writeJson(path.join(p.model, 'catalogs.json'), { schemaVersion: '2.0', endpoints: [{ id: 'create-quote', name: 'Create quote', method: 'POST', path: '/quotes', evidence: [{ path: 'src/Resource.java', startLine: 1 }] }], messageHandlers: [], externalDependencies: [], dataStores: [], scheduledJobs: [] });
-  writeJson(p.plan, { schemaVersion: '2.0', pages: [{ id: 'endpoint-catalog', title: 'Endpoint Catalog', summary: 'HTTP API reference.', category: 'api', mode: 'reference', type: 'reference', order: 1, audience: ['engineer'], coverageTags: ['endpoint-catalog'], query: 'endpoints', requiredSections: [], relatedPages: [] }] });
-  const result = await generate(root);
-  assert.equal(result.providerPages, 0);
+test('reference catalog page is deterministic, traced, auditable, and reusable', async () => {
+  const root = fixture(); const p = catalogFixture(root);
+  const first = await generate(root); const second = await generate(root);
+  assert.equal(first.providerPages, 0); assert.equal(second.providerPages, 0);
   const output = fs.readFileSync(path.join(root, 'docs', 'api', 'endpoint-catalog.md'), 'utf8');
-  assert.match(output, /POST/);
-  assert.match(output, /\/quotes/);
+  assert.match(output, /POST/); assert.match(output, /\/quotes/);
+  const trace = readJson(path.join(p.traceability, 'pages', 'endpoint-catalog.json'));
+  assert.equal(trace.claims.length, 1); assert.equal(trace.claims[0].classification, 'FACT'); assert.equal(trace.claims[0].evidence[0].path, 'src/Resource.java');
+  const quality = await audit(root); assert.equal(quality.pass, true);
   assert.equal(fs.existsSync(path.join(p.telemetry, 'provider-runs.jsonl')), false);
 });
+
+test('deterministic audit rejects FACT evidence outside inventory', async () => {
+  const root = fixture(); const p = catalogFixture(root); await generate(root);
+  const file = path.join(p.traceability, 'pages', 'endpoint-catalog.json'); const trace = readJson(file); trace.claims[0].evidence = [{ path: 'ignored/secret.java' }]; writeJson(file, trace);
+  await assert.rejects(() => audit(root), /Quality failed/);
+});
+
+test('v1 migration preserves docs and ignore policy while archiving workflow state', () => {
+  const root = fixture(); const p = projectPaths(root);
+  writeJson(p.config, { schemaVersion: '1.6', projectName: 'Migrated', commandCode: { executable: 'custom-cmdc', model: 'cheap-model' }, ignore: { useGitignore: true, binary: { maxTextFileBytes: 123456 } } });
+  writeJson(p.project, { schemaVersion: '1.0', kitVersion: '1.0.0' });
+  fs.mkdirSync(path.join(root, 'docs'), { recursive: true }); fs.writeFileSync(path.join(root, 'docs', 'keep.md'), '# Keep\n'); fs.writeFileSync(path.join(root, '.docgenignore'), 'private/**\n');
+  fs.mkdirSync(path.join(p.base, 'evidence'), { recursive: true }); fs.writeFileSync(path.join(p.base, 'evidence', 'legacy.json'), '{}');
+  const run = spawnSync(process.execPath, [cli, 'migrate'], { cwd: root, encoding: 'utf8' });
+  assert.equal(run.status, 0, run.stderr);
+  assert.equal(fs.readFileSync(path.join(root, 'docs', 'keep.md'), 'utf8'), '# Keep\n');
+  assert.equal(fs.readFileSync(path.join(root, '.docgenignore'), 'utf8'), 'private/**\n');
+  const next = readJson(p.config); assert.equal(next.schemaVersion, '2.0'); assert.equal(next.projectName, 'Migrated'); assert.equal(next.commandCode.executable, 'custom-cmdc'); assert.equal(next.ignore.binary.maxTextFileBytes, 123456);
+  const marker = readJson(p.project); assert.match(marker.migrationBackup, /^\.docgen\/migration-backup\//); assert(fs.existsSync(path.join(root, marker.migrationBackup, 'evidence', 'legacy.json')));
+});