Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3585 +/- ##
=======================================
Coverage 98.88% 98.88%
=======================================
Files 886 886
Lines 3061 3061
Branches 540 556 +16
=======================================
Hits 3027 3027
Misses 30 30
Partials 4 4
🚀 New features to boost your workflow:
|
Yes, that would require some changes to the api-docs scripts. Class-Level: faker/scripts/apidocs/output/page.ts Line 76 in 61e4c45 Method-Level: faker/scripts/apidocs/output/page.ts Line 195 in 61e4c45 Note: The later might have impact on the refresh examples button. |
|
I think it's a bit tricky to read partly because of the other commented out code. (Like the CJS imports and the seed). So comments are being used both as a header and to show optional alternatives. Maybe some of the commented lines could be removed or split to another example. |
|
I just revisted this and maybe I have a new idea on how to address this. Then we could put a comment in the first line of each example. E.g. // Default Usecase Maybe we can even replace --- with an hr in post processing. What do you think? |



Currently two examples are joined and it looks quite confusing.
https://deploy-preview-3585.fakerjs.dev/api/faker.html#faker