fix(locale): phone numbers for en_AU#3788
Merged
ST-DDT merged 1 commit intofaker-js:nextfrom Apr 6, 2026
Merged
Conversation
Australian phone numbers were generating invalid numbers because the area code was left as a wildcard (#) allowing 0 and 1 as the first digit. - International: replace '+61#########' with explicit area codes (+612, +613, +617, +618 for landlines, +614 for mobiles) - National: replace '(0#) #### ####' with explicit area codes (02, 03, 07, 08 for landlines, 04 for mobiles) - Human: replace '0# #### ####' and '+61 # #### ####' with explicit area codes See: https://en.wikipedia.org/wiki/Telephone_numbers_in_Australia Closes: faker-js#3574
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3788 +/- ##
=======================================
Coverage 98.88% 98.88%
=======================================
Files 886 886
Lines 3061 3061
Branches 556 540 -16
=======================================
Hits 3027 3027
Misses 30 30
Partials 4 4 🚀 New features to boost your workflow:
|
ST-DDT
approved these changes
Apr 5, 2026
Member
ST-DDT
left a comment
ST-DDT
left a comment
There was a problem hiding this comment.
Looks good to me.
Maybe reduce/remove the redundant comments.
Member
|
@chambois Could you please review this PR as well? |
matthewmayer
approved these changes
Apr 5, 2026
Shinigami92
approved these changes
Apr 5, 2026
ST-DDT
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Australian phone numbers were generating invalid numbers because the area code was left as a wildcard (
#) allowing0and1as the first digit, producing numbers like+61018806128which are not valid Australian phone numbers.Changes
+61#########with explicit area codes+612,+613,+617,+618(NSW/ACT, VIC/TAS, QLD, SA/NT/WA)+614(0#) #### ####with explicit area codes02,03,07,08040# #### ####and+61 # #### ####with explicit area codesReference: Telephone numbers in Australia (Wikipedia)
Related Issue
Closes #3574