Skip to content

chore: reformat person.bio#3803

Merged
xDivisionByZerox merged 1 commit into
nextfrom
chore/person/bio/format
Apr 12, 2026
Merged

chore: reformat person.bio#3803
xDivisionByZerox merged 1 commit into
nextfrom
chore/person/bio/format

Conversation

@ST-DDT
Copy link
Copy Markdown
Member

@ST-DDT ST-DDT commented Apr 12, 2026

PersonModule's biofunction is the only method that uses a deconstructor to access the local data on the entry level.
This causes issues for #3748 and #3189.

This PR reformats/refactors the method to use plain property access instead.

@ST-DDT ST-DDT added this to the vAnytime milestone Apr 12, 2026
@ST-DDT ST-DDT self-assigned this Apr 12, 2026
@ST-DDT ST-DDT requested a review from a team as a code owner April 12, 2026 15:40
@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent m: person Something is referring to the person module labels Apr 12, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 12, 2026

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 6132a4b
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/69dbbceff16d32000803f99d
😎 Deploy Preview https://deploy-preview-3803.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.89%. Comparing base (e765b6b) to head (6132a4b).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3803      +/-   ##
==========================================
- Coverage   98.89%   98.89%   -0.01%     
==========================================
  Files         894      894              
  Lines        3087     3086       -1     
  Branches      564      564              
==========================================
- Hits         3053     3052       -1     
  Misses         30       30              
  Partials        4        4              
Files with missing lines Coverage Δ
src/modules/person/index.ts 94.02% <100.00%> (-0.09%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Apr 12, 2026
@xDivisionByZerox xDivisionByZerox modified the milestones: vAnytime, v10.x Apr 12, 2026
Merged via the queue into next with commit bf58838 Apr 12, 2026
26 checks passed
@xDivisionByZerox xDivisionByZerox deleted the chore/person/bio/format branch April 12, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: chore PR that doesn't affect the runtime behavior m: person Something is referring to the person module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants