feat(locale): add Welsh (cy) postal address definitions#3850
Merged
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
IestynGage
changed the title
IestynGage
changed the title
IestynGage
added a commit
to IestynGage/faker
that referenced
this pull request
May 15, 2026
IestynGage
force-pushed
the
postal_address
branch
from
cd7786c to
b2f3c31
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3850 +/- ##
=======================================
Coverage 98.91% 98.91%
=======================================
Files 905 905
Lines 3146 3146
Branches 564 581 +17
=======================================
Hits 3112 3112
Misses 30 30
Partials 4 4
🚀 New features to boost your workflow:
|
Shinigami92
previously approved these changes
May 18, 2026
ST-DDT
added
p: 1-normal
Member
|
There seems to be merge conflicts. |
IestynGage
force-pushed
the
postal_address
branch
from
b2f3c31 to
9c5d5d8
Compare
ST-DDT
approved these changes
May 18, 2026
matthewmayer
approved these changes
May 19, 2026
Contributor
|
LGTM Current output is something like: 69201 Wellington Street Note US style ZIP code. To make this more realistic, in another PR you could copy in the en_GB postcode implementation. https://github.com/faker-js/faker/blob/next/src/locales/en_GB/location/postcode.ts Or even better, include the relevant Welsh postcode areas in the patterns CF |
Shinigami92
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #3849.
Postal address definitions as ask by @matthewmayer in #3849 (comment). Uses the new county, based on the
EN_GBaddress.