feat(locale): add Welsh (cy) postcode definitions#3851
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
| export default [ | ||
| '{{location.postcode_prefix}}# #??', | ||
| '{{location.postcode_prefix}}## #??', | ||
| ]; |
There was a problem hiding this comment.
The en_GB is just export default ['??# #??', '??## #??']; I suppose you can also add a similiar prefix to en_GB as well. But the postcodes for England, NI, Scotland, Wales, crown dependecies and other special postcodes.
There was a problem hiding this comment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3851 +/- ##
=======================================
Coverage 98.91% 98.91%
=======================================
Files 905 905
Lines 3146 3146
Branches 581 581
=======================================
Hits 3112 3112
Misses 30 30
Partials 4 4
🚀 New features to boost your workflow:
|
Based on the `en_GB` postcode definitions with prefix as recommened by @matthewmayer.
ST-DDT
added
p: 1-normal
There was a problem hiding this comment.
Please make sure to test your changes and verify that they return the expected results
fakerCY.location.zipCode() // "{{location.postcode_prefix}}76 2MM"Currently, the zipcode implementation does not support fake patterns (for default patterns).
This is planned for #3233 / #3176
Until then, you have to cross-product them yourself.
2 participants
Based on the
en_GBpostcode definitions with a prefix as recommened by @matthewmayer in #3850 (comment)