Merge pull request #3052 from faker-ruby/sb-bump-rubocop-minitest

Bump rubocop-minitest and fix rubocop's offense

Author: stefannibrasil

Gemfile

@@ -10,7 +10,7 @@ gem 'minitest', '5.25.4'
 gem 'pry', '0.15.2'
 gem 'rake', '13.2.1'
 gem 'rubocop', '1.73.0'
-gem 'rubocop-minitest', '0.36.0'
+gem 'rubocop-minitest', '0.37.0'
 gem 'rubocop-rake', '0.6.0'
 gem 'simplecov', '0.22.0'
 gem 'test-unit', '3.6.7'

Gemfile.lock

@@ -44,9 +44,10 @@ GEM
       unicode-display_width (>= 2.4.0, < 4.0)
     rubocop-ast (1.38.1)
       parser (>= 3.3.1.0)
-    rubocop-minitest (0.36.0)
+    rubocop-minitest (0.37.0)
+      lint_roller (~> 1.1)
       rubocop (>= 1.61, < 2.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
     ruby-progressbar (1.13.0)
@@ -75,7 +76,7 @@ DEPENDENCIES
   pry (= 0.15.2)
   rake (= 13.2.1)
   rubocop (= 1.73.0)
-  rubocop-minitest (= 0.36.0)
+  rubocop-minitest (= 0.37.0)
   rubocop-rake (= 0.6.0)
   simplecov (= 0.22.0)
   test-unit (= 3.6.7)

lib/helpers/deprecator.rb

@@ -103,7 +103,7 @@ def self.skip_warning
     end
 
     def self.skip_warning?
-      skip == true
+      @skip == true
     end
 
     def self.skip

tasks/reformat_yaml.rake

@@ -2,6 +2,21 @@
 
 require 'yaml'
 
+desc 'Reformat all locales'
+task :reformat_locales do
+  path = File.absolute_path(File.join(__dir__, '..', 'lib', 'locales', '**', '*.yml'))
+  locales = Dir[path]
+  failures = []
+
+  locales.each do |locale_path|
+    reformat_file(locale_path)
+  rescue StandardError => e
+    failures << "Error reformatting #{locale_path}: #{e.message}"
+  end
+
+  puts failures
+end
+
 desc 'Reformat a yaml file into a common format'
 task :reformat_yaml, [:filename] do |_, args|
   args.with_defaults(filename: nil)
@@ -16,7 +31,7 @@ end
 def reformat_file(filename)
   puts "Reformatting #{filename}"
 
-  input = YAML.load_file(filename)
+  input = YAML.safe_load_file(filename, aliases: true)
   # Psych outputs non-indented hypendated array list items.
   output = input.to_yaml(line_width: -1)
                 .gsub(/(^ *- .+$)/, '  \1') # Indent hyphenated list items