Skip to content

Fix nl phone format #3050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefannibrasil merged 2 commits into from
Feb 26, 2025
Merged

Fix nl phone format #3050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9135b2f
Fix Dutch country code
klaaspieter Feb 21, 2025
07bb57e
Separate Dutch phone number formats
klaaspieter Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/locales/nl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,15 @@ nl:
- "#{first_name} #{last_name} #{last_name}"

phone_number:
formats: ["(####) ######", "##########", "06########", "06 #### ####"]
country_code:
- '31'
formats:
- "(####) ######"
- "##########"
cell_phone:
formats:
- "06########"
- "06 #### ####"

university:
prefix: [Universiteit, Hogeschool]
Expand Down
6 changes: 6 additions & 0 deletions test/test_nl_locale.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,12 @@ def test_nl_phone_number_methods
assert_kind_of String, Faker::PhoneNumber.cell_phone
end

def test_nl_cell_phone_countrycode
mobile = Faker::PhoneNumber.cell_phone_with_country_code.gsub(/\D/, '')

assert_match(/^(0|31)/, mobile)
end

def test_nl_university_methods
assert_kind_of String, Faker::University.prefix
assert_kind_of String, Faker::University.name
Expand Down