Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,3 +113,7 @@ Security/Eval:
Style/IfUnlessModifier:
Description: Checks for `if` and `unless` statements that would fit on one line if written as modifier `if`/`unless`. The cop also checks for modifier `if`/`unless` lines that exceed the maximum line length.
Enabled: false

Style/MultipleComparison:
Description: Avoid comparing a variable with multiple items in a conditional, use Array#include? instead.
Enabled: false
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ gem 'benchmark'
gem 'minitest', '5.25.4'
gem 'pry', '0.15.2'
gem 'rake', '13.2.1'
gem 'rubocop', '1.69.2'
gem 'rubocop', '1.73.0'
gem 'rubocop-minitest', '0.36.0'
gem 'rubocop-rake', '0.6.0'
gem 'simplecov', '0.22.0'
Expand Down
18 changes: 10 additions & 8 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@ GEM
docile (1.4.0)
i18n (1.14.7)
concurrent-ruby (~> 1.0)
json (2.9.1)
language_server-protocol (3.17.0.3)
json (2.10.1)
language_server-protocol (3.17.0.4)
lint_roller (1.1.0)
method_source (1.1.0)
minitest (5.25.4)
parallel (1.26.3)
Expand All @@ -30,17 +31,18 @@ GEM
rainbow (3.1.1)
rake (13.2.1)
regexp_parser (2.10.0)
rubocop (1.69.2)
rubocop (1.73.0)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.1.0)
parallel (~> 1.10)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 2.9.3, < 3.0)
rubocop-ast (>= 1.36.2, < 2.0)
rubocop-ast (>= 1.38.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 4.0)
rubocop-ast (1.37.0)
rubocop-ast (1.38.1)
parser (>= 3.3.1.0)
rubocop-minitest (0.36.0)
rubocop (>= 1.61, < 2.0)
Expand All @@ -57,7 +59,7 @@ GEM
test-unit (3.6.7)
power_assert
timecop (0.9.10)
unicode-display_width (3.1.3)
unicode-display_width (3.1.4)
unicode-emoji (~> 4.0, >= 4.0.4)
unicode-emoji (4.0.4)
yard (0.9.37)
Expand All @@ -72,7 +74,7 @@ DEPENDENCIES
minitest (= 5.25.4)
pry (= 0.15.2)
rake (= 13.2.1)
rubocop (= 1.69.2)
rubocop (= 1.73.0)
rubocop-minitest (= 0.36.0)
rubocop-rake (= 0.6.0)
simplecov (= 0.22.0)
Expand Down
2 changes: 1 addition & 1 deletion lib/faker/default/company.rb
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ def indian_gst_number(state_code: nil)
# Construct taxpayer number
gen.group(name: :taxpayer_number) do |g_|
g_.letter(length: 3, ranges: ['A'..'Z'])
g_.letter(length: 1, ranges: [%w[A B C F G H L J P T K]].to_a)
g_.letter(length: 1, ranges: [%w[A B C F G H L J P T K]])
g_.letter(length: 1, ranges: ['A'..'Z'])
g_.int(length: 4, ranges: [0..9999])
g_.letter(length: 1, ranges: ['A'..'Z'])
Expand Down
3 changes: 1 addition & 2 deletions lib/faker/default/national_health_service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ def british_number
# If the check digit is equivalent to 10, the number is invalid.
# See https://en.wikipedia.org/wiki/NHS_number
base_number -= 1 if check_digit(number: base_number) == 10
"#{base_number}#{check_digit(number: base_number)}".to_s
.chars
"#{base_number}#{check_digit(number: base_number)}".chars
.insert(3, ' ')
.insert(7, ' ')
.join
Expand Down