Skip to content

Add airline generator#3072

Closed
wonderer007 wants to merge 2 commits intofaker-ruby:mainfrom
wonderer007:add-airline-generator
Closed

Add airline generator#3072
wonderer007 wants to merge 2 commits intofaker-ruby:mainfrom
wonderer007:add-airline-generator

Conversation

@wonderer007
Copy link
Copy Markdown
Contributor

Motivation / Background

We have been using Faker::Travel::Airport and needed Faker::Travel::Airline, so I created one and opened this PR despite knowing maintainers aren't encouraging new generators.

Checklist

Before submitting the PR, make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug, refactor something, or add a feature.
  • Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

  • Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
  • You've reviewed and followed the Contributing guidelines.

@thdaraujo
Copy link
Copy Markdown
Contributor

thdaraujo commented May 4, 2025

Thanks for your contribution, @wonderer007!

But we are not accepting new generators right now. Please take a look at our Contributing docs to see the types of contributions we are looking for!

--

Similar to #1663

@thdaraujo thdaraujo closed this May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants