fix: clear storage after migration transaction

Author: LouisHaftmann

lib/db.ts

@@ -3,6 +3,7 @@ import { mkdir } from 'node:fs/promises'
 import path from 'node:path'
 import { createSingletonPromise } from '@antfu/utils'
 import SQLite from 'better-sqlite3'
+import { createHooks } from 'hookable'
 import { Kysely, Migrator, MysqlDialect, PostgresDialect, SqliteDialect } from 'kysely'
 import { createPool } from 'mysql2'
 import pg from 'pg'
@@ -135,11 +136,14 @@ export const getDatabase = createSingletonPromise(async () => {
   })
 
   logger.info('Migrating database...')
+  const hooks = createHooks<{
+    afterMigrate: () => Promise<void>
+  }>()
   const migrator = new Migrator({
     db,
     provider: {
       async getMigrations() {
-        return migrations(env.DB_DRIVER)
+        return migrations(env.DB_DRIVER, hooks)
       },
     },
   })
@@ -149,6 +153,7 @@ export const getDatabase = createSingletonPromise(async () => {
     // eslint-disable-next-line unicorn/no-process-exit
     process.exit(1)
   }
+  await hooks.callHook('afterMigrate')
   logger.debug('Migration results', results)
   logger.success('Database migrated')
 

lib/migrations.ts

@@ -1,8 +1,14 @@
+import type { Hookable, Hooks } from 'hookable'
 import type { Migration } from 'kysely'
 import type { Env } from './schemas'
 import { Storage } from './storage'
 
-export function migrations(driver: Env['DB_DRIVER']) {
+export function migrations(
+  driver: Env['DB_DRIVER'],
+  hooks: Hookable<{
+    afterMigrate: () => Promise<void>
+  }>,
+) {
   return {
     $0_init: {
       async up(db) {
@@ -81,14 +87,10 @@ export function migrations(driver: Env['DB_DRIVER']) {
       async up(db) {
         const scopeColumnType = driver === 'mysql' ? 'varchar(255)' : 'text'
 
-        // clear all existing entries
-        const adapter = await Storage.getAdapterFromEnv()
-
         await Promise.all([
           db.deleteFrom('cache_entries').execute(),
           db.deleteFrom('storage_locations').execute(),
           db.deleteFrom('uploads').execute(),
-          adapter.clear(),
         ])
 
         await db.schema
@@ -118,16 +120,17 @@ export function migrations(driver: Env['DB_DRIVER']) {
       async up(db) {
         const repoIdColumnType = driver === 'mysql' ? 'varchar(255)' : 'text'
 
-        // clear all existing entries
-        const adapter = await Storage.getAdapterFromEnv()
-
         await Promise.all([
           db.deleteFrom('cache_entries').execute(),
           db.deleteFrom('storage_locations').execute(),
           db.deleteFrom('uploads').execute(),
-          adapter.clear(),
         ])
 
+        hooks.hook('afterMigrate', async () => {
+          const adapter = await Storage.getAdapterFromEnv()
+          await adapter.clear()
+        })
+
         await db.schema
           .alterTable('cache_entries')
           .addColumn('repoId', repoIdColumnType, (col) => col.notNull())

package.json

@@ -43,6 +43,7 @@
     "croner": "^10.0.1",
     "execa": "^9.6.1",
     "h3": "^1.15.5",
+    "hookable": "^6.1.0",
     "jose": "^6.1.3",
     "kysely": "^0.28.11",
     "mysql2": "3.18.1",