Skip to content

feat(storage/s3): make S3 socket timeout configurable #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devunt wants to merge 2 commits into
base: dev
Choose a base branch
from
+3 −1
Open

feat(storage/s3): make S3 socket timeout configurable #233

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b00f196
feat(storage/s3): make S3 socket timeout configurable
devunt Apr 28, 2026
a3ac365
fix(tests): add STORAGE_S3_SOCKET_TIMEOUT_MS to s3 test env
devunt May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ export const envStorageDriverSchema = type.or(
'AWS_ENDPOINT_URL?': 'string.url',
'AWS_ACCESS_KEY_ID?': 'string',
'AWS_SECRET_ACCESS_KEY?': 'string',
'STORAGE_S3_SOCKET_TIMEOUT_MS': 'number = 10000',
},
{
STORAGE_DRIVER: type.unit('filesystem'),
Expand Down
2 changes: 1 addition & 1 deletion lib/storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ class S3Adapter implements StorageAdapter {
region: env.AWS_REGION,
requestHandler: new NodeHttpHandler({
httpsAgent: agent,
socketTimeout: 3000,
socketTimeout: env.STORAGE_S3_SOCKET_TIMEOUT_MS,
}),
})

Expand Down
Loading