Skip to content

fix(driver): hoist flags declaration to the top of f_sys_accept4_x#2994

Merged
poiana merged 1 commit into
falcosecurity:masterfrom
ekoops:ekoops/fix-kmod
May 12, 2026
Merged

fix(driver): hoist flags declaration to the top of f_sys_accept4_x#2994
poiana merged 1 commit into
falcosecurity:masterfrom
ekoops:ekoops/fix-kmod

Conversation

@ekoops
Copy link
Copy Markdown
Contributor

@ekoops ekoops commented May 12, 2026

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind test

/kind feature

/kind sync

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area automation

/area drivers

/area driver-kmod

/area driver-modern-bpf

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This prevents some build failures if the compilation toolchain uses pedantic flags.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/milestone 10.1.0+driver

Does this PR introduce a user-facing change?:

NONE

This prevents some build failures if the compilation toolchain uses
pedantic flags.

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@github-actions
Copy link
Copy Markdown

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

@ekoops
Copy link
Copy Markdown
Contributor Author

ekoops commented May 12, 2026

Testing against kernel/distro matrix: https://github.com/falcosecurity/libs/actions/runs/25742128518/job/75595174915

@ekoops
Copy link
Copy Markdown
Contributor Author

ekoops commented May 12, 2026

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

False positive. I'm gonna unhold once the CI is green

@irozzo-1A irozzo-1A self-requested a review May 12, 2026 14:49
Copy link
Copy Markdown
Contributor

@irozzo-1A irozzo-1A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-project-automation github-project-automation Bot moved this from Todo to In progress in Falco Roadmap May 12, 2026
@poiana
Copy link
Copy Markdown
Contributor

poiana commented May 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, irozzo-1A, leogr, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.73%. Comparing base (1cbbe78) to head (9a05bcf).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2994   +/-   ##
=======================================
  Coverage   75.73%   75.73%           
=======================================
  Files         299      299           
  Lines       33164    33164           
  Branches     5168     5168           
=======================================
  Hits        25116    25116           
  Misses       8048     8048           
Flag Coverage Δ
libsinsp 75.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekoops
Copy link
Copy Markdown
Contributor Author

ekoops commented May 12, 2026

X64 Matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.10 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟢 🟢 🟡
centos-4.18 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟢 🟢 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟡
ubuntu-6.5 🟢 🟢 🟢 🟢

ARM64 Matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢

@ekoops
Copy link
Copy Markdown
Contributor Author

ekoops commented May 12, 2026

/hold cancel

@poiana poiana merged commit 24e21bf into falcosecurity:master May 12, 2026
54 of 56 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in Falco Roadmap May 12, 2026
@ekoops ekoops deleted the ekoops/fix-kmod branch May 12, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants