fix(libscap): wire savefile converter objects into the savefile engine#3011
Open
immanuwell wants to merge 1 commit into
Open
fix(libscap): wire savefile converter objects into the savefile engine#3011immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
poiana
added
release-note-none
dco-signoff: yes
kind/bug
Contributor
|
Welcome @immanuwell! It looks like this is your first PR to falcosecurity/libs 🎉 |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: immanuwell The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Perf diff from master - unit testsHeap diff from master - unit testsHeap diff from master - scap fileBenchmarks diff from master |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3011 +/- ##
=======================================
Coverage 75.65% 75.65%
=======================================
Files 299 299
Lines 32936 32936
Branches 5118 5118
=======================================
Hits 24919 24919
Misses 8017 8017
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind bug
/area build
/area libscap-engine-savefile
/area tests
What this PR does / why we need it:
This fixes a real build break in the documented
libscap_testflow.scap_engine_savefilewas pulling the converter OBJECT library viatarget_link_libraries(). With Unix Makefiles that leaveslibscap_testin a bad spot,make libscap_testcan fail withNo rule to make target ... converter.cpp.o. Kinda sneaky.This switches the savefile engine to consume those object files through
target_sources($<TARGET_OBJECTS:...>), so the objects are wired into the static archive the right way.Which issue(s) this PR fixes:
None found.
Special notes for your reviewer:
Repro:
cmake -S . -B build-libscap-check \ -DUSE_BUNDLED_DEPS=ON \ -DCREATE_TEST_TARGETS=ON \ -DBUILD_DRIVER=OFF \ -DENABLE_LIBSCAP_TESTS=ON cmake --build build-libscap-check --target libscap_test -j2Before this patch, the build can fail with
No rule to make target ... scap_savefile_converter.dir/converter.cpp.o.After this patch,
libscap_testbuilds ok,./build-libscap-check/test/libscap/libscap_testpasses, and a cleanscapbuild still works.Does this PR introduce a user-facing change?: