beta release#1079
Open
wbazant wants to merge 4 commits into
Open
Conversation
Also, change view syntax
Deploying falling-fruit-web with
|
| Latest commit: |
67522d8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3f57c8a6.falling-fruit-web.pages.dev |
| Branch Preview URL: | https://issue-1070.falling-fruit-web.pages.dev |
Collaborator
|
@wbazant Thanks for going neck-deep to investigate!
Some additional thoughts on the URLs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1070
@ezwelty how do you feel about an enhancement to drop
@from the view syntax? I've confused myself with the test cases I used and gone in completely the wrong direction, wrote code to change how we store path segments, and then it didn't solve the issue. Easy to put it back in or remove but now that I look at the URL without@, I like it a bit more, and now is a great time to change URLs.Closes #1068
I made the change to keep drawer state in params. Same commit because it also changes
src/utils/appUrl.jsa lot. It's definitely better - for example there's a skeleton loader shown when going from list to location - and we could maybe use params whenever there's a separate app view, like in the report modal.On the other hand, it's harder to write transitions in this way. When keeping state in Redux, you can observe changes in state and make dispatches asynchronously, and have separate files for each individual tiny thing like e.g. a location marker on a map, but with url params, they start to clash with each other and make race conditions.
We have code for managing URLs to maintain view and params, so I added a new rule to it - a param with empty value is dropped - and whenever I navigate away from the context of panes I add
?pane=&tab=to reset the pane and tab.Closes #1076
Closes #1078