Commit 872b423
committed
fix: comprehensive review fixes across all crates and packages
Codec:
- Fix VLQ_MAX_SHIFT from 64 to 60 (matching comment, prevents silent i64 overflow)
- Add missing assert!() in overflow test (was silently passing)
- Fix broken encode_parallel intra-doc link
- Add vlq_decode_unsigned/vlq_encode_unsigned to README API table
- Fix stale "single-char fast path" performance claim in README
Scopes:
- Fix H-tag variable index decoder to accumulate deltas (was reading as absolute)
- Add VLQ drain for 4 orphaned tag handlers (prevents stream corruption)
- Remove dead code in encoder's None-scope handling
- Add readme/keywords/categories to Cargo.toml
- Add SubRangeBinding and ScopesError to README types table
- Fix module doc example to use empty names vec
Remapping:
- Implement ignore_list propagation in remap and remap_streaming
- Add bounds check for source index in remap_streaming
- Introduce MappingParams struct (fixes too_many_arguments clippy)
- Fix docstrings ("Finish building" -> "Serialize the current state")
- Fix README: full remap_streaming signature, accurate allocation claims
Generator:
- Replace duplicate vlq_encode_unsigned_inline with srcmap_codec export
- Move serde/serde_json to dev-dependencies
- Remove unused CallSite import and unnecessary as u32 cast
- Add missing StreamingGenerator methods to README
- Add Panics doc to StreamingGenerator::to_decoded_map
Sourcemap:
- Fix Mapping struct size doc (24 -> 28 bytes)
- Replace duplicate vlq_encode_unsigned with codec import
- Fix unnecessary all_sources.clone() in from_sections
- Fix .len() >= 1 to !.is_empty()
- Add doc comment to from_vlq_with_range_mappings
- Comprehensive README API table update (~15 missing methods/types)
Packages:
- Fix WASM allMappingsFlat test (12 -> 14, 7 fields per mapping)
- Add NAPI source()/name() methods (declared in .d.ts but not implemented)
- Add missing TS declarations (hasRangeMappings, rangeMappingCount, encodedRangeMappings)
- Update all 14 platform sub-package versions from 0.1.2 to 0.1.3
- Add detect-libc dependency to both NAPI packages
- Add missing lifecycle scripts to @srcmap/sourcemap
- Fix README Int32Array -> number[] type documentation
Project:
- Fix repository URL casing in workspace Cargo.toml
- Consolidate criterion to workspace.dependencies
- Add srcmap-symbolicate and symbolicate-wasm to release.yml
- Add missing packages to root test scripts
- Add benchmarks/fixtures/ to root .gitignore
- Fix clippy warning in symbolicate crate1 parent ee8bbc7 commit 872b423
46 files changed
Lines changed: 901 additions & 427 deletions
File tree
- .github/workflows
- crates
- codec
- src
- generator
- src
- remapping
- benches
- src
- scopes
- src
- sourcemap
- src
- symbolicate/src
- packages
- codec
- npm
- darwin-arm64
- darwin-x64
- linux-arm64-gnu
- linux-arm64-musl
- linux-x64-gnu
- linux-x64-musl
- win32-x64-msvc
- sourcemap-wasm/__tests__
- sourcemap
- npm
- darwin-arm64
- darwin-x64
- linux-arm64-gnu
- linux-arm64-musl
- linux-x64-gnu
- linux-x64-musl
- win32-x64-msvc
- src
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
47 | 55 | | |
48 | 56 | | |
49 | 57 | | |
| |||
179 | 187 | | |
180 | 188 | | |
181 | 189 | | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
182 | 194 | | |
183 | | - | |
| 195 | + | |
184 | 196 | | |
185 | 197 | | |
186 | 198 | | |
| |||
203 | 215 | | |
204 | 216 | | |
205 | 217 | | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
206 | 225 | | |
207 | 226 | | |
208 | 227 | | |
| |||
255 | 274 | | |
256 | 275 | | |
257 | 276 | | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
258 | 283 | | |
259 | 284 | | |
260 | 285 | | |
| |||
297 | 322 | | |
298 | 323 | | |
299 | 324 | | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
300 | 329 | | |
301 | 330 | | |
302 | 331 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
13 | 16 | | |
14 | 17 | | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
69 | | - | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
70 | 72 | | |
71 | 73 | | |
72 | 74 | | |
| |||
83 | 85 | | |
84 | 86 | | |
85 | 87 | | |
86 | | - | |
| 88 | + | |
87 | 89 | | |
88 | 90 | | |
89 | 91 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | 59 | | |
63 | 60 | | |
64 | 61 | | |
65 | | - | |
66 | 62 | | |
67 | 63 | | |
68 | | - | |
69 | | - | |
70 | | - | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
71 | 67 | | |
72 | 68 | | |
73 | | - | |
74 | 69 | | |
75 | 70 | | |
76 | | - | |
77 | 71 | | |
78 | 72 | | |
79 | | - | |
80 | 73 | | |
81 | 74 | | |
82 | | - | |
83 | 75 | | |
84 | 76 | | |
85 | | - | |
86 | 77 | | |
87 | 78 | | |
88 | 79 | | |
89 | 80 | | |
90 | 81 | | |
91 | 82 | | |
92 | | - | |
93 | 83 | | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
94 | 98 | | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
102 | 102 | | |
103 | 103 | | |
104 | 104 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
239 | 239 | | |
240 | 240 | | |
241 | 241 | | |
242 | | - | |
| 242 | + | |
243 | 243 | | |
244 | | - | |
| 244 | + | |
245 | 245 | | |
246 | 246 | | |
247 | 247 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
59 | 65 | | |
60 | 66 | | |
61 | 67 | | |
| |||
129 | 135 | | |
130 | 136 | | |
131 | 137 | | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
132 | 144 | | |
133 | 145 | | |
134 | 146 | | |
| |||
238 | 250 | | |
239 | 251 | | |
240 | 252 | | |
241 | | - | |
| 253 | + | |
| 254 | + | |
242 | 255 | | |
243 | 256 | | |
244 | 257 | | |
| |||
294 | 307 | | |
295 | 308 | | |
296 | 309 | | |
297 | | - | |
| 310 | + | |
298 | 311 | | |
299 | 312 | | |
300 | 313 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | 23 | | |
26 | 24 | | |
27 | 25 | | |
28 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
0 commit comments