Skip to content

Commit 46d58a5

Browse files
committed
pin handlers.test_register.RegistrationTestCase.test_auto_create_auto_join_room_preset_invalid_permissions() to room version 11
A new default of room version 12 means that this test case can not happen as is. The room creator's power level can not be moved from infinite so will always have the permission to invite a new member
1 parent 226af72 commit 46d58a5

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

tests/handlers/test_register.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -477,6 +477,7 @@ def test_auto_create_auto_join_room_preset_guest(self) -> None:
477477
"auto_join_rooms": ["#room:test"],
478478
"autocreate_auto_join_room_preset": "private_chat",
479479
"auto_join_mxid_localpart": "support",
480+
"default_room_version": "11",
480481
}
481482
)
482483
def test_auto_create_auto_join_room_preset_invalid_permissions(self) -> None:
@@ -485,6 +486,8 @@ def test_auto_create_auto_join_room_preset_invalid_permissions(self) -> None:
485486
registration doesn't completely break if the inviter doesn't have proper
486487
permissions.
487488
"""
489+
# This test is limited to room version 11, as after that the room creator will
490+
# always have permission to invite users and make any other changes they wish.
488491
inviter = "@support:test"
489492

490493
# Register an initial user to create the room and such (essentially this
@@ -528,7 +531,7 @@ def test_auto_create_auto_join_room_preset_invalid_permissions(self) -> None:
528531
)
529532
)
530533

531-
# Register a second user, which won't be be in the room (or even have an invite)
534+
# Register a second user, which won't be in the room (or even have an invite)
532535
# since the inviter no longer has the proper permissions.
533536
user_id = self.get_success(self.handler.register_user(localpart="bob"))
534537

0 commit comments

Comments
 (0)