Skip to content

Commit 8fe99b0

Browse files
committed
Maintain timeout increase for test_lock_contention() from #39
1 parent 8278f31 commit 8fe99b0

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

tests/handlers/test_worker_lock.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,11 @@ def test_lock_contention(self) -> None:
6969
f"Adjusting test_lock_contention: timeout={timeout_seconds}s"
7070
)
7171
else:
72-
# Settings for other architectures
73-
timeout_seconds = 5
72+
# Settings for other architectures. The 5 seconds originally given to this
73+
# test was insufficient when under load. Sometimes it would fail on CI. For
74+
# lack of a better/reliable Twisted mechanism option, this uses signal which
75+
# watches wallclock time instead of Twisted's simulated time.
76+
timeout_seconds = 15
7477
# It takes around 0.5s on a 5+ years old laptop
7578
with test_timeout(timeout_seconds): # Use the dynamically set timeout
7679
d = self._take_locks(

0 commit comments

Comments
 (0)