fix: Allow account deactivation even with disabled profile changes#84
Merged
Merged
Conversation
jason-famedly
force-pushed
the
jason/gedisa-displaynames-erasure
branch
from
August 6, 2025 17:46
89d206c to
3f034f2
Compare
jason-famedly
marked this pull request as ready for review
August 6, 2025 17:47
nico-famedly
reviewed
Aug 7, 2025
jason-famedly
force-pushed
the
jason/gedisa-displaynames-erasure
branch
from
August 7, 2025 11:03
3f034f2 to
3133e62
Compare
nico-famedly
approved these changes
Aug 7, 2025
jason-famedly
force-pushed
the
jason/gedisa-displaynames-erasure
branch
3 times, most recently
from
August 7, 2025 15:17
47ba26a to
8feabda
Compare
… profile data is disabled in configuration Specifically, to check if this is a deactivation and that it is being set to `""` for an GDPR level erasure
jason-famedly
force-pushed
the
jason/gedisa-displaynames-erasure
branch
from
August 7, 2025 15:22
8feabda to
ed17248
Compare
jason-famedly
added a commit
that referenced
this pull request
Mar 27, 2026
jason-famedly
added a commit
that referenced
this pull request
Mar 27, 2026
The 'deactivation' argument was removed from the profile handler setting methods. Will have to use another method Keeping the tests
jason-famedly
added a commit
that referenced
this pull request
Mar 30, 2026
The 'deactivation' argument was removed from the profile handler setting methods. Will have to use another method Keeping the tests
jason-famedly
added a commit
that referenced
this pull request
Mar 30, 2026
The 'deactivation' argument was removed from the profile handler setting methods. Will have to use another method Keeping the tests
jason-famedly
added a commit
that referenced
this pull request
Mar 30, 2026
The 'deactivation' argument was removed from the profile handler setting methods. Will have to use another method Keeping the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes famedly/product-management#3334
Although
displaynameandavatar_urlwere discussed, this does not touch the MSC4133 arbitrary profile fields. If you need this too, let me know