fix: simplify further

Author: fancybear-dev

Dockerfile

@@ -8,14 +8,11 @@ ARG VECTOR_VERSION
 
 WORKDIR "C:/Program Files/Vector"
 
+ADD install-vector.ps1 /windows/temp/install-vector.ps1
+
 SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]
 
-RUN Write-Host "VECTOR_VERSION: $env:VECTOR_VERSION" ; `
-    $url = "https://github.com/vectordotdev/vector/releases/download/v${env:VECTOR_VERSION}/vector-${env:VECTOR_VERSION}-x86_64-pc-windows-msvc.zip" ; `
-    Write-Host "Download URL: $url" ; `
-    Invoke-WebRequest -UseBasicParsing -Uri $url -OutFile "vector.zip" ; `
-    Expand-Archive -Path "vector.zip" -DestinationPath "." ; `
-    Remove-Item "vector.zip" -Force
+RUN /windows/temp/install-vector.ps1 -VectorVersion $VECTOR_VERSION
 
 RUN setx /M PATH "%PATH%;C:\Program Files\Vector\bin"
 

install-vector.ps1

@@ -0,0 +1,11 @@
+param(
+    [Parameter(Mandatory=$true)]
+    [string]$VectorVersion
+)
+
+Write-Host "VECTOR_VERSION: $VectorVersion"
+$url = "https://github.com/vectordotdev/vector/releases/download/v${VectorVersion}/vector-${VectorVersion}-x86_64-pc-windows-msvc.zip"
+Write-Host "Download URL: $url"
+Invoke-WebRequest -UseBasicParsing -Uri $url -OutFile "vector.zip"
+Expand-Archive -Path "vector.zip" -DestinationPath "."
+Remove-Item "vector.zip" -Force