Skip to content

Commit 3c10154

Browse files
committed
aggregator reset tests
1 parent 4196b17 commit 3c10154

2 files changed

Lines changed: 46 additions & 0 deletions

File tree

sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/internal/state/AsynchronousMetricStorageTest.java

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -502,4 +502,25 @@ void enabledThenDisableThenEnable_recordAndCollect(MemoryMode memoryMode) {
502502

503503
assertThat(longCounterStorage.collect(resource, scope, 0, 0).isEmpty()).isFalse();
504504
}
505+
506+
@ParameterizedTest
507+
@EnumSource(MemoryMode.class)
508+
void disableDropsAggregatorState(MemoryMode memoryMode) {
509+
setup(memoryMode);
510+
511+
longCounterStorage.record(Attributes.empty(), 10);
512+
513+
longCounterStorage.setEnabled(false);
514+
longCounterStorage.setEnabled(true);
515+
516+
longCounterStorage.record(Attributes.empty(), 5);
517+
518+
MetricData metricData = longCounterStorage.collect(resource, scope, 0, 0);
519+
assertThat(metricData)
520+
.hasLongSumSatisfying(
521+
sum ->
522+
sum.satisfies(
523+
sumData ->
524+
assertThat(sumData.getPoints()).allMatch(point -> point.getValue() == 5d)));
525+
}
505526
}

sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/internal/state/SynchronousMetricStorageTest.java

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -897,4 +897,29 @@ void enabledThenDisableThenEnable_recordAndCollect(MemoryMode memoryMode) {
897897

898898
assertThat(storage.collect(RESOURCE, INSTRUMENTATION_SCOPE_INFO, 0, 10).isEmpty()).isFalse();
899899
}
900+
901+
@ParameterizedTest
902+
@EnumSource(MemoryMode.class)
903+
void disableDropsAggregatorState(MemoryMode memoryMode) {
904+
initialize(memoryMode);
905+
906+
DefaultSynchronousMetricStorage<?, ?> storage =
907+
new DefaultSynchronousMetricStorage<>(
908+
deltaReader, METRIC_DESCRIPTOR, aggregator, attributesProcessor, CARDINALITY_LIMIT);
909+
910+
storage.recordDouble(10d, Attributes.empty(), Context.current());
911+
912+
storage.setEnabled(false);
913+
storage.setEnabled(true);
914+
915+
storage.recordDouble(5d, Attributes.empty(), Context.current());
916+
917+
MetricData metricData = storage.collect(RESOURCE, INSTRUMENTATION_SCOPE_INFO, 0, 10);
918+
assertThat(metricData)
919+
.hasDoubleSumSatisfying(
920+
sum ->
921+
sum.satisfies(
922+
sumData ->
923+
assertThat(sumData.getPoints()).allMatch(point -> point.getValue() == 5d)));
924+
}
900925
}

0 commit comments

Comments
 (0)