Is it necessary to advise elfeed-feed-list?

[minad]

@fasheng Why don't you use the elfeed-feeds variable directly? Note that you can specify options as plist in elfeed-feeds. See for example the options :fetch-link or :no-update which are supported by the newest Elfeed. Is it still necessary to keep elfeed-protocol-feeds?

[minad]

Btw there is another incompatibility. I added an optional argument ALL to elfeed-feed-list. If we could avoid the advice it would be better.

[minad]

See emacs-elfeed/elfeed@a0b1781

[fasheng]

Well, in fact elfeed-protocol use elfeed-feeds at first. elfeed-protocol-feeds was just created to fix compatibility issues with other extensions(like elfeed-org and elfeed-summary) later. Especially elfeed-org, it always reset elfeed-feeds and do not provide a method to keep the custom value(elfeed-protocol could not defined in elfeed.org for it requires meta data like :password). And elfeed-summary did similar bad things.

I think elfeed-feeds was designed to have two different functions(feeds and autotags) contributes to the issues, so elfeed-protocol just create a new variable to avoid similar cases.

Looks elfeed-fetch-functions and :no-update are good features. They solved parts of the problem and some hack code is still necessary. I will try to switch back to elfeed-feeds, and a new branch feat/use-elfeed-feeds was created to test related code.

https://github.com/fasheng/elfeed-protocol/blob/feat/use-elfeed-feeds/elfeed-protocol.el#L176

[minad]

Okay, thanks. I would appreciate if you switch back and then the other packages could be fixed. By supporting plists as part of elfeed-feeds we gain a lot of flexibility, also for additional configuration parameters which you may need?

[fasheng]

Thanks! Not needed at the moment, I have tested a lot of the code today and it all seems to work. Except for some minor issues.

[fasheng]

Hi, @shimeike @ak-ionos @Vietoonet, thanks for the debugging work before. Now elfeed-protocol switch back to variable elfeed-feeds again, and it will work together with extensions like elfeed-org and elfeed-summary without any additional setup. Please notice it when you updating the package and feedback if something wrong.

[shimeike]

Hi @fasheng , all seems good on my end. Thank you for your work to align with @minad !!