⚰️ More cleanup to reuse existing interface and remove stale const

Author: savannahostrowski

src/cloud/commands/logs.ts

@@ -16,17 +16,17 @@ const SINCE_OPTIONS = [
   { label: "1 day", value: "1d" },
 ]
 
-// Roughly matches fastapi-cloud-cli LOG_LEVEL_COLORS
-const LEVEL_COLORS: Record<string, string> = {
-  debug: "#4488ff",
-  info: "#00cccc",
-  warning: "#ccaa00",
-  warn: "#ccaa00",
-  error: "#f14c4c",
-  critical: "#cc66cc",
-  fatal: "#cc66cc",
-  default: "#888",
-}
+// Levels recognized when inferring a log's level from its message prefix.
+// Pipe colors for these live in the webview stylesheet, keyed on [data-level].
+const KNOWN_LEVELS = [
+  "debug",
+  "info",
+  "warning",
+  "warn",
+  "error",
+  "critical",
+  "fatal",
+]
 
 const FILTER_CHIPS = [
   { level: "debug", label: "DEBUG" },
@@ -41,12 +41,7 @@ function formatTimestamp(ts: string): string {
   return Number.isNaN(d.getTime()) ? ts : `${d.toISOString().slice(0, 23)}Z`
 }
 
-const MESSAGE_LEVEL_RE = new RegExp(
-  `^\\s*(${Object.keys(LEVEL_COLORS)
-    .filter((k) => k !== "default")
-    .join("|")})\\b`,
-  "i",
-)
+const MESSAGE_LEVEL_RE = new RegExp(`^\\s*(${KNOWN_LEVELS.join("|")})\\b`, "i")
 
 function normalizeLevel(level: string, message?: string): string {
   // The streaming API returns "unknown" for new logs (Loki limitation) so try to infer from message prefix
@@ -60,13 +55,10 @@ function normalizeLevel(level: string, message?: string): string {
   return resolved
 }
 
-export interface FormattedLogEntry {
-  level: string
-  timestamp: string
-  message: string
-}
-
-export function formatLogEntry(entry: AppLogEntry): FormattedLogEntry {
+// Returns the entry with its level normalized and timestamp formatted. Same
+// shape as the raw entry, but the webview builds the DOM node itself
+// (className/dataset/textContent), so no HTML escaping is required here.
+export function formatLogEntry(entry: AppLogEntry): AppLogEntry {
   const rawLevel = (entry.level ?? "info").toLowerCase()
   const level = normalizeLevel(rawLevel, entry.message)
   return {

src/cloud/ui/panel/webview.ts

@@ -1,6 +1,8 @@
 /// <reference lib="dom" />
 /// <reference lib="dom.iterable" />
 
+import type { AppLogEntry } from "../../api"
+
 declare function acquireVsCodeApi(): { postMessage(msg: unknown): void }
 
 const vscode = acquireVsCodeApi()
@@ -129,15 +131,9 @@ function setStreamingState(streaming: boolean, appLabel?: string): void {
     streaming && appLabel ? `Streaming logs for ${appLabel}...` : ""
 }
 
-interface LogEntry {
-  level: string
-  timestamp: string
-  message: string
-}
-
 // Build the log line as a DOM node. The untrusted message is set as a text
 // node, so it is never parsed as HTML — no sanitization needed.
-function buildLogLine(entry: LogEntry): HTMLElement {
+function buildLogLine(entry: AppLogEntry): HTMLElement {
   const line = document.createElement("div")
   line.className = "log-line"
   line.dataset.level = entry.level