Fix flashing

Author: savannahostrowski

src/cloud/commands/deploy.ts

@@ -126,6 +126,7 @@ export async function deploy(context: DeployContext): Promise<boolean> {
   }
 
   try {
+    // Set status immediately to prevent flash from config watcher triggering refresh
     updateStatus("Creating deployment...")
     const deployment = await apiService.createDeployment(config.app_id)
 
@@ -148,6 +149,9 @@ export async function deploy(context: DeployContext): Promise<boolean> {
     )
 
     if (result) {
+      // Update status bar to show success before showing the message
+      statusBarItem.text = `$(cloud) ${config.app_slug ?? "Deployed"}`
+
       const action = await ui.showInformationMessage(
         "Deployed successfully!",
         "Open App",

src/cloud/controller.ts

@@ -275,16 +275,21 @@ export class CloudController {
   async deploy(workspaceRoot?: vscode.Uri): Promise<void> {
     const root = workspaceRoot ?? this.getActiveWorkspaceFolder()
 
-    await deploy({
+    const success = await deploy({
       workspaceRoot: root,
       configService: this.configService,
       apiService: this.apiService,
       statusBarItem: this.statusBarItem,
     })
 
     if (root) {
+      // Refresh state in background without updating status bar during refresh
+      // This avoids a flash when deploy succeeds (status bar is already correct)
       await this.refresh(root)
-      await this.statusBarManager.update()
+      // Only update status bar on failure - success already set it correctly
+      if (!success) {
+        await this.statusBarManager.update()
+      }
     }
   }
 

src/cloud/ui/statusBar.ts

@@ -59,12 +59,19 @@ export class StatusBarManager {
 
       const state = this.getState(activeFolder)
 
+      // Don't interrupt an active deployment (spinning icon)
+      if (this.statusBarItem.text.includes("$(sync~spin)")) {
+        return
+      }
+
       switch (state.status) {
         case "not_configured":
         case "error":
-        case "refreshing":
           this.statusBarItem.text = STATUS_DEPLOY
           break
+        case "refreshing":
+          // Don't change status bar during refresh to avoid flashing
+          break
         case "linked":
           this.statusBarItem.text = `$(cloud) ${state.app.slug}`
           break

src/test/cloud/ui/pickers.test.ts

@@ -146,12 +146,10 @@ suite("cloud/ui/pickers", () => {
       })
 
       sinon.stub(vscode.window, "showInputBox").resolves("my-app")
-      const infoStub = sinon.stub(ui, "showInformationMessage")
 
       const result = await createNewApp(api, team1, "default-name")
 
       assert.deepStrictEqual(result, createdApp)
-      assert.ok(infoStub.calledOnce)
     })
 
     test("returns null when user cancels input", async () => {