Skip to content

Commit 18227b0

Browse files
committed
✅ Update tests for new password verification and update logic
1 parent c9c1f53 commit 18227b0

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

backend/tests/api/routes/test_login.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,8 @@ def test_reset_password(client: TestClient, db: Session) -> None:
9999
assert r.json() == {"message": "Password updated successfully"}
100100

101101
db.refresh(user)
102-
assert verify_password(new_password, user.hashed_password)
102+
verified, _ = verify_password(new_password, user.hashed_password)
103+
assert verified
103104

104105

105106
def test_reset_password_invalid_token(

backend/tests/api/routes/test_users.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,8 @@ def test_update_password_me(
242242
user_db = db.exec(user_query).first()
243243
assert user_db
244244
assert user_db.email == settings.FIRST_SUPERUSER
245-
assert verify_password(new_password, user_db.hashed_password)
245+
verified, _ = verify_password(new_password, user_db.hashed_password)
246+
assert verified
246247

247248
# Revert to the old password to keep consistency in test
248249
old_data = {
@@ -257,7 +258,8 @@ def test_update_password_me(
257258
db.refresh(user_db)
258259

259260
assert r.status_code == 200
260-
assert verify_password(settings.FIRST_SUPERUSER_PASSWORD, user_db.hashed_password)
261+
verified, _ = verify_password(settings.FIRST_SUPERUSER_PASSWORD, user_db.hashed_password)
262+
assert verified
261263

262264

263265
def test_update_password_me_incorrect_password(
@@ -331,7 +333,8 @@ def test_register_user(client: TestClient, db: Session) -> None:
331333
assert user_db
332334
assert user_db.email == username
333335
assert user_db.full_name == full_name
334-
assert verify_password(password, user_db.hashed_password)
336+
verified, _ = verify_password(password, user_db.hashed_password)
337+
assert verified
335338

336339

337340
def test_register_user_already_exists_error(client: TestClient) -> None:

backend/tests/crud/test_user.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,4 +88,5 @@ def test_update_user(db: Session) -> None:
8888
user_2 = db.get(User, user.id)
8989
assert user_2
9090
assert user.email == user_2.email
91-
assert verify_password(new_password, user_2.hashed_password)
91+
verified, _ = verify_password(new_password, user_2.hashed_password)
92+
assert verified

0 commit comments

Comments
 (0)