Skip to content

Commit 458fddd

Browse files
vicayaYuriiMotov
andauthored
✅ Fix incorrect mocking in unit tests (issue #1780) (#1781)
Co-authored-by: Yurii Motov <yurii.motov.monte@gmail.com>
1 parent 608bb80 commit 458fddd

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

backend/tests/scripts/test_backend_pre_start.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,13 @@ def test_init_successful_connection() -> None:
99
engine_mock = MagicMock()
1010

1111
session_mock = MagicMock()
12-
exec_mock = MagicMock(return_value=True)
13-
session_mock.configure_mock(**{"exec.return_value": exec_mock})
12+
session_mock.__enter__.return_value = session_mock
13+
14+
select1 = select(1)
1415

1516
with (
16-
patch("sqlmodel.Session", return_value=session_mock),
17+
patch("app.backend_pre_start.Session", return_value=session_mock),
18+
patch("app.backend_pre_start.select", return_value=select1),
1719
patch.object(logger, "info"),
1820
patch.object(logger, "error"),
1921
patch.object(logger, "warn"),
@@ -28,6 +30,4 @@ def test_init_successful_connection() -> None:
2830
connection_successful
2931
), "The database connection should be successful and not raise an exception."
3032

31-
assert session_mock.exec.called_once_with(
32-
select(1)
33-
), "The session should execute a select statement once."
33+
session_mock.exec.assert_called_once_with(select1)

backend/tests/scripts/test_test_pre_start.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,13 @@ def test_init_successful_connection() -> None:
99
engine_mock = MagicMock()
1010

1111
session_mock = MagicMock()
12-
exec_mock = MagicMock(return_value=True)
13-
session_mock.configure_mock(**{"exec.return_value": exec_mock})
12+
session_mock.__enter__.return_value = session_mock
13+
14+
select1 = select(1)
1415

1516
with (
16-
patch("sqlmodel.Session", return_value=session_mock),
17+
patch("app.tests_pre_start.Session", return_value=session_mock),
18+
patch("app.tests_pre_start.select", return_value=select1),
1719
patch.object(logger, "info"),
1820
patch.object(logger, "error"),
1921
patch.object(logger, "warn"),
@@ -28,6 +30,4 @@ def test_init_successful_connection() -> None:
2830
connection_successful
2931
), "The database connection should be successful and not raise an exception."
3032

31-
assert session_mock.exec.called_once_with(
32-
select(1)
33-
), "The session should execute a select statement once."
33+
session_mock.exec.assert_called_once_with(select1)

0 commit comments

Comments
 (0)