Skip to content

Commit a847760

Browse files
amosttAygentic
andcommitted
fix(ci): correct CI workflow paths, build context, and branch gate
Fix 5 issues found during automated code review: - BUG-001: Docker build context now uses repo root (.) matching compose.yml - BUG-002: Replace invalid `bun ci` with `bun install --frozen-lockfile` - FUNC-001: Fix lint/mypy paths to use `app/` relative to working-directory - FUNC-002: Add frontend-ci to alls-green gate with allowed-skips - SEC-001: Create root .dockerignore to exclude secrets from build context Related to AYG-72 🤖 Generated by Aygentic Co-Authored-By: Aygentic <noreply@aygentic.com>
1 parent d9b0450 commit a847760

2 files changed

Lines changed: 36 additions & 6 deletions

File tree

.dockerignore

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
# Secrets
2+
.env
3+
.env.*
4+
!.env.example
5+
6+
# Version control
7+
.git
8+
.github
9+
10+
# IDE
11+
.vscode
12+
.idea
13+
14+
# Dependencies (installed in container)
15+
node_modules
16+
frontend/node_modules
17+
18+
# Caches and build artifacts
19+
**/__pycache__
20+
**/.mypy_cache
21+
**/.pytest_cache
22+
**/htmlcov
23+
**/.coverage
24+
**/.ruff_cache
25+
26+
# Documentation and config
27+
docs/
28+
*.md
29+
!backend/README.md

.github/workflows/ci.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@ jobs:
2626
run: uv sync
2727
working-directory: backend
2828
- name: Ruff check
29-
run: uv run ruff check backend/app/
29+
run: uv run ruff check app/
3030
working-directory: backend
3131
- name: Ruff format check
32-
run: uv run ruff format --check backend/app/
32+
run: uv run ruff format --check app/
3333
working-directory: backend
3434
- name: Mypy
35-
run: uv run mypy backend/app
35+
run: uv run mypy app
3636
working-directory: backend
3737

3838
backend-test:
@@ -82,7 +82,7 @@ jobs:
8282
- name: Setup Bun
8383
uses: oven-sh/setup-bun@v2
8484
- name: Install dependencies
85-
run: bun ci
85+
run: bun install --frozen-lockfile
8686
working-directory: frontend
8787
- name: Lint
8888
run: bun run lint
@@ -99,16 +99,17 @@ jobs:
9999
- name: Checkout
100100
uses: actions/checkout@v6
101101
- name: Build backend image
102-
run: docker build -t test-backend backend/ -f backend/Dockerfile
102+
run: docker build -t test-backend . -f backend/Dockerfile
103103

104104
# Branch protection gate
105105
alls-green:
106106
name: CI Complete
107107
runs-on: ubuntu-latest
108-
needs: [backend-lint, backend-test, docker-build]
108+
needs: [backend-lint, backend-test, docker-build, frontend-ci]
109109
if: always()
110110
steps:
111111
- name: Check all jobs
112112
uses: re-actors/alls-green@release/v1
113113
with:
114114
jobs: ${{ toJSON(needs) }}
115+
allowed-skips: frontend-ci

0 commit comments

Comments
 (0)