Closed
Conversation
Member
|
Hi @alexrockhill, Biome also needed to be updated to the latest version, so in the latest upgrade #1861 (which also required extra changes), I included this fix proposed here as well. Thank you for reporting! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, on
master,cd frontend; npm run linthangs and gives a warning:This is because it is trying to lint
dist. If you fix that, it errors out on the generated backend client:The fundamental issue is that
openapi-tsis not and probably reasonably will not always be up to date with the latest biome formatting. (I was able to fix these errors pretty quickly but since they're generated it's not helpful but I can back-contribute up toopenapi-ts). I looked into it but unfortunately because there's only one biome.json file, it's not possible to call format in generating the client and callnpm run lintthat ignores that formatted client code. So, sadly, I think you need to ignore it and not lint the generated code. It's already pretty nice though. This is what I would do, there's other approaches but I think it's an issue thatnpm run lintdoesn't work and this is one option to fix it.Also #1098 did not actually work, I'm not sure why.