Skip to content

🔒️ Add zizmor and fix audit findings#2260

Draft
YuriiMotov wants to merge 15 commits intomasterfrom
setup-zizmor
Draft

🔒️ Add zizmor and fix audit findings#2260
YuriiMotov wants to merge 15 commits intomasterfrom
setup-zizmor

Conversation

@YuriiMotov
Copy link
Copy Markdown
Member

@YuriiMotov YuriiMotov commented Apr 16, 2026

Changes applied:

  • Setup daily interval and 7 days cooldown period for Dependabot
  • Ignored dangerous-triggers rule for pull_request_target and workflow_run (checked that they are used in a safe way)
  • Specified minimal permissions on workflow level, moved permissions to the job level
  • Ignored secrets-outside-env rule as using the environments would require approval for each run (and without required approvals it wouldn't make sense)
  • Specified environment for deploy-staging.yml and deploy-production.yml workflows to protect secrets, updated deployment docs
  • Added persist-credentials: false for actions/checkout when persisting is not needed by other steps
  • Specified version of uv to install for astral-sh/setup-uv (Note that Dependabot will not upgrade it, but Renovate can do it)
  • Specified run condition in latest-changes to make it clear that it only runs for merged PRs
  • Replaced uvx prek command with uv run prek - uvx uses latest version (unpinned), it's better to use locked version
  • Added zizmor pre-commit hook

Added smokeshow and zizmor dependencies to root level project as I think they should be there.
I think we should also move prek there and maybe other dev dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants