Add warning when pattern is passed via schema_extra

Author: YuriiMotov

sqlmodel/main.py

@@ -400,6 +400,12 @@ def Field(
             DeprecationWarning,
             stacklevel=2,
         )
+    if "pattern" in current_schema_extra:
+        warnings.warn(
+            "Pass `pattern` parameter directly to Field instead of passing it via `schema_extra`",
+            DeprecationWarning,
+            stacklevel=2,
+        )
 
     # Extract possible alias settings from schema_extra so we can control precedence
     schema_validation_alias = current_schema_extra.pop("validation_alias", None)

tests/test_pydantic/test_field.py

@@ -79,8 +79,13 @@ class DateModel(SQLModel):
 
 
 def test_field_pattern_via_schema_extra():
-    class DateModel(SQLModel):
-        date_1: str = Field(schema_extra={"pattern": r"^\d{2}-\d{2}-\d{4}$"})
+    with pytest.warns(
+        DeprecationWarning,
+        match="Pass `pattern` parameter directly to Field instead of passing it via `schema_extra`",
+    ):
+
+        class DateModel(SQLModel):
+            date_1: str = Field(schema_extra={"pattern": r"^\d{2}-\d{2}-\d{4}$"})
 
     with pytest.raises(ValidationError):
         DateModel(date_1="incorrect")