Skip to content

Supporting pydantic custom root models as columns#168

Closed
5cat wants to merge 2 commits into
fastapi:mainfrom
5cat:main
Closed

Supporting pydantic custom root models as columns#168
5cat wants to merge 2 commits into
fastapi:mainfrom
5cat:main

Conversation

@5cat

@5cat 5cat commented Nov 27, 2021

Copy link
Copy Markdown

Resolves #7

the approach was to wrap the model around a custom type similar to the SQLAlchemy documentation example .

although i thought about using hypothesis but it will introduce another dependency so i just typed arbitrary values for the tests since i didnt care about the individual values but their types.

So now it is possible to use pydantic custom root type models as column types.

there are some types that do not work with sqlite so i made pytest skip them

@Fanna1119

Copy link
Copy Markdown

Status on the merge of this? It's quite crucial.

@antont

antont commented Feb 18, 2022

Copy link
Copy Markdown

Status on the merge of this? It's quite crucial.

I figure a good strategy now is to just merge what you need in your own fork. I suppose tiangolo checks these when he has time, but there's a long list so I wouldn't wait with anything crucial.

@tiangolo tiangolo added feature New feature or request investigate labels Oct 22, 2023
@tiangolo

Copy link
Copy Markdown
Member

Thanks @5cat and everyone, let's switch first to the discussion in #7, I need to understand the use case and why this would be needed/wanted.

@github-actions

Copy link
Copy Markdown
Contributor

As this PR has been waiting for the original user for a while but seems to be inactive, it's now going to be closed. But if there's anyone interested, feel free to create a new PR.

@github-actions github-actions Bot closed this Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request investigate waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom Root Types are detected as NullType by SQLAlchemy

4 participants