🐛 Make FieldInfoMetadata hashable to fix Annotated type usage in sets#1889
Open
Yuerchu wants to merge 3 commits intofastapi:mainfrom
Open
🐛 Make FieldInfoMetadata hashable to fix Annotated type usage in sets#1889Yuerchu wants to merge 3 commits intofastapi:mainfrom
FieldInfoMetadata hashable to fix Annotated type usage in sets#1889Yuerchu wants to merge 3 commits intofastapi:mainfrom
Conversation
…sets Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
Could you please add the test that fails on |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
Added 3 test cases in
Tests 1 and 2 fail on |
Member
|
Not exactly what I meant) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FieldInfoMetadatais a plain@dataclasswith implicit__eq__, which causes Python to set__hash__toNone. WhenFieldInfoMetadatainstances are used as metadata insidetyping.Annotatedtypes,Annotated.__hash__fails because it callshash((origin, metadata_tuple))and theFieldInfoMetadataelement is unhashable.This breaks FastAPI's OpenAPI schema generation in
get_definitions(), which collects field annotations into aset:Fix
Add
unsafe_hash=Trueto the@dataclassdecorator. This is safe becauseFieldInfoMetadatainstances are effectively immutable after construction — they are created once during model class definition and never mutated afterward.Reproduction
Any project using custom
Annotatedfield types withFieldInfoMetadatain the metadata (e.g. viasqlmodel_extor similar libraries) will fail to generate/openapi.jsonwith:🤖 Generated with Claude Code