Skip to content

⬆️ Update ruff from 0.2.0 to 0.4.1 and fix deprecated scripts…#902

Closed
ryankwondev wants to merge 2 commits intofastapi:mainfrom
ryankwondev:240424-ruff-deprecated-commands-update
Closed

⬆️ Update ruff from 0.2.0 to 0.4.1 and fix deprecated scripts…#902
ryankwondev wants to merge 2 commits intofastapi:mainfrom
ryankwondev:240424-ruff-deprecated-commands-update

Conversation

@ryankwondev
Copy link
Copy Markdown

⬆️ Update ruff from 0.2.0 to 0.4.1 and fix deprecated scripts commands

  • Upgraded the "ruff = "0.2.0"" dependency in pyproject.toml to "ruff = "0.4.1"".
  • Due to the ruff version upgrade, using the ruff [dir] format has been deprecated (warning: ruff is deprecated. Use ruff check instead.).
  • Accordingly, updated the commands in format.sh and lint.sh script.
  • The readability of existing files has been improved by applying new rules and formatting.

🚨 DEAR MAINTAINERS,

As a result of the impact of bullet point no. 4, the format of the ... return type has been uniformly changed. If this change is undesirable, it seems that additional formatting rules need to be added.

before:

        bind_arguments: Optional[Dict[str, Any]] = None,
        _parent_execute_state: Optional[Any] = None,
        _add_event: Optional[Any] = None,
    ) -> TupleResult[_TSelectParam]:
        ...

after:

        bind_arguments: Optional[Dict[str, Any]] = None,
        _parent_execute_state: Optional[Any] = None,
        _add_event: Optional[Any] = None,
    ) -> TupleResult[_TSelectParam]: ...

@ryankwondev
Copy link
Copy Markdown
Author

(+) I think the cause of the pre-commit process, impact of bullet point no. 4, does not seem to be present in this PR's file diff.

@github-actions
Copy link
Copy Markdown
Contributor

📝 Docs preview for commit ceb442e at: https://188583b9.sqlmodel.pages.dev

@tiangolo
Copy link
Copy Markdown
Member

Thanks! This was covered in another PR, so I'll close this one now. ☕

@tiangolo tiangolo closed this Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants