Update progress on eof

Author: YuriiMotov

src/fastapi_cloud_cli/utils/progress_file.py

@@ -22,7 +22,8 @@ def read(self, n=-1):
         data = self._file.read(n)
         self._bytes_read += len(data)
         now_ = datetime.now().timestamp()
-        if now_ - self._last_update_time >= self._update_interval:
+        is_eof = (len(data) == 0) or (n > 0 and len(data) < n)
+        if (now_ - self._last_update_time >= self._update_interval) or is_eof:
             self._progress_callback(self._bytes_read)
             self._last_update_time = now_
         return data

tests/test_progress_file.py

@@ -76,6 +76,15 @@ def test_callback_tracks_cumulative_bytes() -> None:
 
     mock_callback.assert_has_calls([call(10), call(30), call(40)])
 
+def test_callback_called_on_eof() -> None:
+    file = _make_file(b"abcd")
+    mock_callback = Mock()
+
+    pf = ProgressFile(file, progress_callback=mock_callback)
+    pf.read(3)
+    pf.read(3)
+    mock_callback.assert_has_calls([call(3), call(4)])
+
 
 def test_name_property() -> None:
     file = _make_file(name="test.tar.gz")