Return sorted list from _get_large_files

Author: YuriiMotov

src/fastapi_cloud_cli/commands/deploy.py

@@ -149,7 +149,7 @@ def _get_large_files(path: Path, threshold_mb: int) -> list[tuple[Path, int]]:
         if file_size >= threshold_bytes:
             large_files.append((filename.relative_to(path), file_size))
 
-    return large_files
+    return sorted(large_files, key=lambda x: x[1], reverse=True)
 
 
 class Team(BaseModel):
@@ -834,8 +834,7 @@ def deploy(
                     f"⚠️  Some uploaded files are larger than {large_file_threshold} MB ⚖️ :",
                     tag="warning",
                 )
-                top_3 = sorted(large_files, key=lambda x: x[1], reverse=True)[:3]
-                for fname, fsize in top_3:
+                for fname, fsize in large_files[:3]:
                     fsize_mb = fsize // (1024 * 1024)
                     toolkit.print(f" • {fname} [yellow]({fsize_mb} MB)[/yellow]")
                 is_more = len(large_files) > 3

tests/test_deploy_utils.py

@@ -161,9 +161,9 @@ def test_get_large_files_returns_files_at_or_above_threshold(tmp_path: Path) ->
 
     result = _get_large_files(tmp_path, threshold_mb=1)
 
-    assert sorted(result, key=lambda x: x[1]) == [
-        (Path("big.bin"), 2 * 1024 * 1024),
+    assert result == [
         (Path("subdir") / "huge.bin", 5 * 1024 * 1024),
+        (Path("big.bin"), 2 * 1024 * 1024),
     ]