Skip to content

Commit 72b9829

Browse files
authored
Merge branch 'main' into prek
2 parents 5c351ab + f15bfd8 commit 72b9829

File tree

4 files changed

+19
-5
lines changed

4 files changed

+19
-5
lines changed

.github/workflows/smokeshow.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ permissions:
1010

1111
jobs:
1212
smokeshow:
13-
if: ${{ github.event.workflow_run.conclusion == 'success' }}
1413
runs-on: ubuntu-latest
1514

1615
steps:
@@ -20,7 +19,7 @@ jobs:
2019
run: echo "$GITHUB_CONTEXT"
2120
- uses: actions/setup-python@v5
2221
with:
23-
python-version: '3.9'
22+
python-version: '3.13'
2423

2524
- run: pip install smokeshow
2625

.github/workflows/test.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ jobs:
4040
pydantic-version: "v1"
4141
fail-fast: false
4242
runs-on: ubuntu-latest
43+
env:
44+
UV_PYTHON: ${{ matrix.python-version }}
4345
steps:
4446
- name: Dump GitHub context
4547
env:
@@ -107,14 +109,14 @@ jobs:
107109
- run: uv sync --locked --all-extras --dev
108110
- run: ls -la coverage
109111
- run: uv run coverage combine coverage
110-
- run: uv run coverage report
111112
- run: uv run coverage html --title "Coverage for ${{ github.sha }}"
112113
- name: Store coverage HTML
113114
uses: actions/upload-artifact@v4
114115
with:
115116
name: coverage-html
116117
path: htmlcov
117118
include-hidden-files: true
119+
- run: uv run coverage report --fail-under=100
118120

119121
# https://github.com/marketplace/actions/alls-green#why
120122
check: # This job does nothing and is only used for the branch protection

release-notes.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,19 @@
22

33
## Latest Changes
44

5+
### Fixes
6+
7+
* 🐛 Fix CI ran all tests on oldest supported Python. PR [#136](https://github.com/fastapilabs/fastapi-cloud-cli/pull/136) by [@DoctorJohn](https://github.com/DoctorJohn).
8+
9+
### Refactors
10+
11+
* ♻️ Reorder log messages for deployment readiness. PR [#137](https://github.com/fastapilabs/fastapi-cloud-cli/pull/137) by [@alejsdev](https://github.com/alejsdev).
12+
13+
### Internal
14+
15+
* 👷 Configure coverage, error on main tests, don't wait for Smokeshow. PR [#134](https://github.com/fastapilabs/fastapi-cloud-cli/pull/134) by [@YuriiMotov](https://github.com/YuriiMotov).
16+
* 👷 Run Smokeshow always, even on test failures. PR [#133](https://github.com/fastapilabs/fastapi-cloud-cli/pull/133) by [@YuriiMotov](https://github.com/YuriiMotov).
17+
518
## 0.7.0
619

720
### Features

src/fastapi_cloud_cli/commands/deploy.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -376,13 +376,13 @@ def _wait_for_deployment(
376376
if log.type == "complete":
377377
progress.log("")
378378
progress.log(
379-
f"🐔 Ready the chicken! Your app is ready at [link={deployment.url}]{deployment.url}[/link]"
379+
f"You can also check the app logs at [link={deployment.dashboard_url}]{deployment.dashboard_url}[/link]"
380380
)
381381

382382
progress.log("")
383383

384384
progress.log(
385-
f"You can also check the app logs at [link={deployment.dashboard_url}]{deployment.dashboard_url}[/link]"
385+
f"🐔 Ready the chicken! Your app is ready at [link={deployment.url}]{deployment.url}[/link]"
386386
)
387387

388388
break

0 commit comments

Comments
 (0)