💄 Update how we show messages

Shortcake-Parent: main

Author: patrick91

src/fastapi_cloud_cli/commands/deploy.py

@@ -468,6 +468,7 @@ def _wait_for_deployment(
         ) as progress,
         APIClient() as client,
     ):
+        progress.metadata["done_emoji"] = "🚀"
         try:
             for log in client.stream_build_logs(deployment.id):
                 time_elapsed = time.monotonic() - started_at
@@ -476,6 +477,7 @@ def _wait_for_deployment(
                     progress.log(Text.from_ansi(log.message.rstrip()))
 
                 if log.type == "complete":
+                    progress.title = "Build complete!"
                     progress.log("")
                     progress.log(
                         f"You can also check the app logs at [link={deployment.dashboard_url}]{deployment.dashboard_url}[/link]"
@@ -756,6 +758,7 @@ def deploy(
                 toolkit.progress(title="Creating deployment") as progress,
                 handle_http_errors(progress),
             ):
+                progress.metadata["done_emoji"] = "📦"
                 logger.debug("Creating deployment for app: %s", app.id)
                 deployment = _create_deployment(app.id)
 

src/fastapi_cloud_cli/utils/cli.py

@@ -40,7 +40,7 @@ def _get_tag_segments(
         tag = emojis[self.animation_counter % len(emojis)]
 
         if done:
-            tag = emojis[-1]
+            tag = metadata.get("done_emoji", emojis[-1])
 
         left_padding = self.tag_width - 1
         left_padding = max(0, left_padding)

tests/test_cli_deploy.py

@@ -2,7 +2,7 @@
 import string
 from datetime import timedelta
 from pathlib import Path
-from typing import Optional, TypedDict
+from typing import TypedDict
 from unittest.mock import patch
 
 import httpx
@@ -37,14 +37,14 @@ class RandomApp(TypedDict):
     slug: str
     id: str
     team_id: str
-    directory: Optional[str]
+    directory: str | None
 
 
 def _get_random_app(
     *,
-    slug: Optional[str] = None,
-    team_id: Optional[str] = None,
-    directory: Optional[str] = None,
+    slug: str | None = None,
+    team_id: str | None = None,
+    directory: str | None = None,
 ) -> RandomApp:
     name = "".join(random.choices(string.ascii_lowercase, k=10))
     slug = slug or "".join(random.choices(string.ascii_lowercase, k=10))
@@ -62,7 +62,7 @@ def _get_random_app(
 
 def _get_random_deployment(
     *,
-    app_id: Optional[str] = None,
+    app_id: str | None = None,
     status: str = "waiting_upload",
 ) -> dict[str, str]:
     id = "".join(random.choices(string.digits, k=10))
@@ -1314,7 +1314,7 @@ def build_logs_handler(request: httpx.Request, route: respx.Route) -> Response:
     with changing_dir(tmp_path), patch("time.sleep"):
         result = runner.invoke(app, ["deploy"])
 
-        assert "short wait message" in result.output
+        assert "Build complete!" in result.output
 
 
 @pytest.mark.respx
@@ -1382,7 +1382,7 @@ def build_logs_handler(request: httpx.Request, route: respx.Route) -> Response:
     with changing_dir(tmp_path), patch("time.sleep"):
         result = runner.invoke(app, ["deploy"])
 
-        assert "long wait message" in result.output
+        assert "Build complete!" in result.output
 
 
 @pytest.mark.respx