✅ Refactor tests

Author: patrick91

tests/conftest.py

@@ -25,15 +25,18 @@ def setup_terminal() -> None:
 
 
 @pytest.fixture
-def logged_in_cli() -> Generator[None, None, None]:
-    with patch("fastapi_cloud_cli.utils.auth.get_auth_token", return_value=True):
-        yield
+def logged_in_cli(temp_auth_config) -> Generator[None, None, None]:
+    # Create auth file with test token
+    temp_auth_config.write_text('{"access_token": "test_token_12345"}')
+    yield
 
 
 @pytest.fixture
-def logged_out_cli() -> Generator[None, None, None]:
-    with patch("fastapi_cloud_cli.utils.auth.get_auth_token", return_value=None):
-        yield
+def logged_out_cli(temp_auth_config) -> Generator[None, None, None]:
+    # Ensure no auth file exists
+    if temp_auth_config.exists():
+        temp_auth_config.unlink()
+    yield
 
 
 @dataclass
@@ -54,3 +57,10 @@ def configured_app(tmp_path: Path) -> ConfiguredApp:
     config_path.write_text(f'{{"app_id": "{app_id}", "team_id": "{team_id}"}}')
 
     return ConfiguredApp(app_id=app_id, team_id=team_id, path=tmp_path)
+
+
+@pytest.fixture
+def temp_auth_config(tmp_path: Path) -> Generator[Path, None, None]:
+    """Provides a temporary auth config setup for testing file operations."""
+    with patch("fastapi_cloud_cli.utils.config.get_config_folder", return_value=tmp_path):
+        yield tmp_path / "auth.json"

tests/test_cli_login.py

@@ -33,7 +33,7 @@ def test_shows_a_message_if_something_is_wrong(respx_mock: respx.MockRouter) ->
 
 
 @pytest.mark.respx(base_url=settings.base_api_url)
-def test_full_login(respx_mock: respx.MockRouter) -> None:
+def test_full_login(respx_mock: respx.MockRouter, temp_auth_config) -> None:
     with patch("fastapi_cloud_cli.commands.login.typer.launch") as mock_open:
         respx_mock.post(
             "/login/device/authorization", data={"client_id": settings.client_id}
@@ -55,11 +55,19 @@ def test_full_login(respx_mock: respx.MockRouter) -> None:
                 "client_id": settings.client_id,
                 "grant_type": "urn:ietf:params:oauth:grant-type:device_code",
             },
-        ).mock(return_value=Response(200, json={"access_token": "1234"}))
+        ).mock(return_value=Response(200, json={"access_token": "test_token_1234"}))
+
+        # Verify no auth file exists before login
+        assert not temp_auth_config.exists()
 
         result = runner.invoke(app, ["login"])
 
         assert result.exit_code == 0
         assert mock_open.called
         assert mock_open.call_args.args == ("http://test.com",)
         assert "Now you are logged in!" in result.output
+        
+        # Verify auth file was created with correct content
+        assert temp_auth_config.exists()
+        auth_content = temp_auth_config.read_text()
+        assert '"access_token":"test_token_1234"' in auth_content

tests/test_cli_logout.py

@@ -0,0 +1,36 @@
+from typer.testing import CliRunner
+
+from fastapi_cloud_cli.cli import app
+
+runner = CliRunner()
+
+
+def test_logout_with_existing_auth_file(temp_auth_config):
+    # Create auth file
+    temp_auth_config.write_text('{"access_token": "test_token"}')
+    
+    # Verify file exists before logout
+    assert temp_auth_config.exists()
+    
+    result = runner.invoke(app, ["logout"])
+    
+    # Verify logout was successful
+    assert result.exit_code == 0
+    assert "You are now logged out! 🚀" in result.output
+    
+    # Verify auth file was deleted
+    assert not temp_auth_config.exists()
+
+
+def test_logout_with_no_auth_file(temp_auth_config):
+    # Verify no auth file exists
+    assert not temp_auth_config.exists()
+    
+    result = runner.invoke(app, ["logout"])
+    
+    # Verify logout was successful even without auth file
+    assert result.exit_code == 0
+    assert "You are now logged out! 🚀" in result.output
+    
+    # Verify no auth file was created
+    assert not temp_auth_config.exists()