🐛 Exclude .env files from deployment uploads (#150)

Author: patrick91

src/fastapi_cloud_cli/commands/deploy.py

@@ -62,6 +62,9 @@ def _should_exclude_entry(path: Path) -> bool:
     if path.suffix == ".pyc":
         return True
 
+    if path.name == ".env" or path.name.startswith(".env."):
+        return True
+
     return False
 
 

tests/test_archive.py

@@ -143,12 +143,13 @@ def test_archive_respects_fastapicloudignore_unignore(
     }
 
 
-def test_archive_includes_hidden_files(
+def test_archive_includes_hidden_files_but_excludes_env(
     src_path: Path, tar_path: Path, dst_path: Path
 ) -> None:
-    """Should include hidden files in the archive by default."""
+    """Should include hidden files but exclude .env files."""
     (src_path / "main.py").write_text("print('hello')")
     (src_path / ".env").write_text("SECRET_KEY=xyz")
+    (src_path / ".env.local").write_text("LOCAL_KEY=abc")
     (src_path / ".config").mkdir()
     (src_path / ".config" / "settings.json").write_text('{"setting": "value"}')
 
@@ -159,7 +160,6 @@ def test_archive_includes_hidden_files(
 
     assert set(dst_path.glob("**/*")) == {
         dst_path / "main.py",
-        dst_path / ".env",
         dst_path / ".config",
         dst_path / ".config" / "settings.json",
     }

tests/test_deploy_utils.py

@@ -19,6 +19,11 @@
         Path(".venv"),
         Path("__pycache__"),
         Path("module.pyc"),
+        Path("/project/.env"),
+        Path("/project/.env.local"),
+        Path("/project/.env.production"),
+        Path(".env"),
+        Path(".env.development"),
     ],
 )
 def test_excludes_paths(path: Path) -> None:
@@ -37,6 +42,8 @@ def test_excludes_paths(path: Path) -> None:
         Path("/project/src/module.pyx"),  # similar to .pyc but different
         Path("/project/config.json"),
         Path("/project/README.md"),
+        Path("/project/.envrc"),  # not a .env file
+        Path("/project/env.py"),  # not a .env file
     ],
 )
 def test_includes_paths(path: Path) -> None: