Merged
Conversation
patrick91
reviewed
Jan 9, 2026
Collaborator
patrick91
left a comment
patrick91
left a comment
There was a problem hiding this comment.
This looks great, I did push a couple of commits, but I was also wondering if we can update the code to be more similar to what we do for the deploy logs (for example using the attempts decorator and adding the stream logs function to or APIClient)?
Member
Author
|
Oh, wow. I completely missed that we had that. That'll be much simpler, will refactor a bit! |
savannahostrowski
force-pushed
the
logs_command
branch
2 times, most recently
from
c013021 to
e839475
Compare
patrick91
approved these changes
Jan 13, 2026
Collaborator
patrick91
left a comment
patrick91
left a comment
There was a problem hiding this comment.
Awesome work! Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically built this to test out https://github.com/fastapilabs/cloud/pull/2163 (so we need to wait until that's settled before merging this)
Tested manually via interactive logs and piped to a file.
Screen.Recording.2025-12-17.at.4.07.22.PM.mov