🐛 Fix FASTAPI_CLOUD_TOKEN always overrides user token

[YuriiMotov]

This PR implements alternative approach to solve the same issue as #174

For now, if you have FASTAPI_CLOUD_TOKEN set and try to use any command, it will always use deploy token (see sources)

This PR turns Identity into a just storage, and moves token selection logic to APIClient. Now we can parameterize APIClient to use user token or deployment token depending on the context (command used).

Now if user runs fastapi login and FASTAPI_CLOUD_TOKEN is set, it will show a warning:

fastapi login

And on fastapi deploy command, we also notify that deployment token is being used:

fastapi deploy

---

As a side effect I updated the output of whoami command.
Now it checks both user token and deployment token:

Details

Not logged in, but deployment token is set:

No credentials found. Use `fastapi login` to login.
⚡ Using API token from environment variable for `fastapi deploy` command.

Logged in, and deployment token is set:

⚡ somebody@example.com
⚡ Using API token from environment variable for `fastapi deploy` command.

Without deployment token:

⚡ somebody@example.com

---

Additionally added a unset_env_vars fixture that ensures FASTAPI_CLOUD_TOKEN set on host machine doesn't break tests (currently on master tests will fail if you have FASTAPI_CLOUD_TOKEN set)

[YuriiMotov]

Instantiate APIClient here instead of accepting it as a parameter because at the moment this function is called there is no APIClient instance yet in deploy. We can off course instantiate APIClient earlier in deploy, but it would increase indentation

[YuriiMotov]

The way GitHub shows diff of deploy command starting from this line is total mess..
Changes are not that big actually.
It's just:

• printing info message in case deployment token is used
• increasing the indentation caused by with APIClient()
• using client.handle_http_errors instead of handle_http_errors
• passing client parameter to some functions
• passing arguments by names instead of positional arguments

It looks much better in VSCode

[YuriiMotov]

_handle_unauthorized and handle_http_error were just moved from cli module with the following diff:

Details

-def handle_unauthorized() -> str:
+def _handle_unauthorized(auth_mode: AuthMode) -> str:
    message = "The specified token is not valid. "
 
-    identity = Identity()
-
-    if identity.auth_mode == "user":
+    if auth_mode == "user":
         delete_auth_config()
 
        message += "Use `fastapi login` to generate a new token."
    else:
        message += "Make sure to use a valid token."

    return message
 
 
-def handle_http_error(error: HTTPError, default_message: str | None = None) -> str:
+def handle_http_error(
+    error: httpx.HTTPError,
+    default_message: str | None = None,
+    auth_mode: AuthMode = "user",
+) -> str:
     message: str | None = None
 
-    if isinstance(error, HTTPStatusError):
+    if isinstance(error, httpx.HTTPStatusError):
         status_code = error.response.status_code
 
         # Handle validation errors from Pydantic models, this should make it easier to debug :)
        if status_code == 422:
            logger.debug(error.response.json())  # pragma: no cover

         elif status_code == 401:
-            message = handle_unauthorized()
+            message = _handle_unauthorized(auth_mode=auth_mode)
 
         elif status_code == 403:
             message = "You don't have permissions for this resource"


    if not message:
        message = (
            default_message
            or f"Something went wrong while contacting the FastAPI Cloud server. Please try again later. \n\n{error}"
        )

    return message

[YuriiMotov]

handle_http_errors was just moved from cli module with the following diff (omitted indentation for clearer diff):

Details

-@contextlib.contextmanager
+@contextmanager
 def handle_http_errors(
+    self,
     progress: Progress,
     default_message: str | None = None,
 ) -> Generator[None, None, None]:
     try:
         yield
-    except ReadTimeout as e:
+    except httpx.ReadTimeout as e:
         logger.debug(e)
 
         progress.set_error(
-            "The request to the FastAPI Cloud server timed out. Please try again later."
+            "The request to the FastAPI Cloud server timed out."
+            " Please try again later."
         )
 
         raise typer.Exit(1) from None
-    except HTTPError as e:
+    except httpx.HTTPError as e:
         logger.debug(e)
 
-        message = handle_http_error(e, default_message)
+        message = handle_http_error(e, default_message, auth_mode=self.auth_mode)
 
         progress.set_error(message)

        raise typer.Exit(1) from None

[YuriiMotov]

Previously, is_logged_in meant any of user token or deploy token exist. I think it was not very good naming (is_authenticated would be better).
Now is_logged_in is only about the user token (obtained as a result of login procedure).
Hope it will not be confusing (for me it's not).

[YuriiMotov]

That was very annoying that tests stopped working when I had FASTAPI_CLOUD_TOKEN set on my machine.. Took me time to understand what is happening..

[YuriiMotov]

This is not necessary for this PR, I just noticed that this use case wasn't covered by tests

[buurro]

Thank you for addressing this!

[patrick91]

Nice work! I've left a couple of nit comments 😊