Skip to content

♻️ Rename app_slug parameter of _get_app to app_id #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrick91 merged 1 commit into from
May 5, 2026
Merged

♻️ Rename app_slug parameter of _get_app to app_id #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/fastapi_cloud_cli/commands/deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,8 @@ def progress_callback(bytes_read: int) -> None:
logger.debug("Upload notification sent successfully")


def _get_app(client: APIClient, app_slug: str) -> AppResponse | None:
response = client.get(f"/apps/{app_slug}")
def _get_app(client: APIClient, app_id: str) -> AppResponse | None:
response = client.get(f"/apps/{app_id}")

if response.status_code == 404:
return None
Expand Down Expand Up @@ -793,7 +793,7 @@ def deploy(
with toolkit.progress("Checking app...", transient=True) as progress:
with client.handle_http_errors(progress):
logger.debug("Checking app with ID: %s", target_app_id)
app = _get_app(client=client, app_slug=target_app_id)
app = _get_app(client=client, app_id=target_app_id)

if not app:
logger.debug("App not found in API")
Expand Down
Loading