Skip to content

Commit 892a89d

Browse files
committed
Remove unneeded check from CALL_LIST_APPEND
1 parent 50753e8 commit 892a89d

4 files changed

Lines changed: 9 additions & 29 deletions

File tree

Include/internal/pycore_opcode_metadata.h

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Python/bytecodes.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4361,24 +4361,19 @@ dummy_func(
43614361
PyStackRef_CLOSE(callable);
43624362
res = retval ? PyStackRef_True : PyStackRef_False;
43634363
assert((!PyStackRef_IsNull(res)) ^ (_PyErr_Occurred(tstate) != NULL));
4364-
#if TIER_ONE
4365-
// Skip the following CHECK_PERIODIC.
4366-
assert(next_instr->op.code == CHECK_PERIODIC);
4367-
SKIP_OVER(1);
4368-
#endif
43694364
}
43704365

43714366
macro(CALL_ISINSTANCE) =
43724367
unused/1 +
43734368
unused/2 +
43744369
_GUARD_THIRD_NULL +
43754370
_GUARD_CALLABLE_ISINSTANCE +
4376-
_CALL_ISINSTANCE;
4371+
_CALL_ISINSTANCE +
4372+
_SKIP_CHECK_PERIODIC;
43774373

43784374
macro(CALL_LIST_APPEND) =
43794375
unused/1 +
43804376
unused/2 +
4381-
CHECK_PERIODIC + // Do this first to avoid deopting in the middle of the qinstruction
43824377
_GUARD_CALLABLE_LIST_APPEND +
43834378
_GUARD_NOS_NOT_NULL +
43844379
_GUARD_NOS_LIST +

Python/executor_cases.c.h

Lines changed: 0 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Python/generated_cases.c.h

Lines changed: 3 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)