Global: fixes issues raised by AI

Author: CarterLi

scripts/gen-amdgpuids.py

@@ -7,7 +7,7 @@ def main(amdgpu_ids_path: str):
         full_text = f.read()
 
     if full_text == '':
-        sys.exit('Error: pci.ids file is empty')
+        sys.exit(f'Error: {amdgpu_ids_path} file is empty')
 
     products = []
     for line in full_text.split('\n'):

scripts/gen-pciids.py

@@ -19,7 +19,7 @@ def main(keep_vendor_list: set, pci_ids_path: str):
         full_text = f.read()
 
     if full_text == '':
-        sys.exit('Error: pci.ids file is empty')
+        sys.exit(f'Error: {pci_ids_path} file is empty')
 
     dev_list_text = full_text[:full_text.rfind('\n\n\n')]  # remove known classes
     for line in dev_list_text.split('\n'):

src/detection/font/font_windows.c

@@ -48,6 +48,9 @@ const char* ffDetectFontImpl(FFFontResult* result)
 
     for (uint32_t i = 0; i < ARRAY_SIZE(fonts); ++i)
     {
+        if (fontBuffers[i].length != sizeof(LOGFONTW))
+            continue; // Invalid data, skip
+
         LOGFONTW* logFont = &fonts[i];
 
         ffStrbufSetWS(&result->fonts[i], logFont->lfFaceName);

src/detection/terminalsize/terminalsize_windows.c

@@ -33,7 +33,7 @@ bool ffDetectTerminalSize(FFTerminalSizeResult* result)
         return false;
 
     {
-        CONSOLE_FONT_INFOEX cfi;
+        CONSOLE_FONT_INFOEX cfi = { .cbSize = sizeof(cfi) };
         if(GetCurrentConsoleFontEx(hOutput, FALSE, &cfi)) // Only works for ConHost
         {
             result->width = result->columns * (uint16_t) cfi.dwFontSize.X;

src/logo/image/image.c

@@ -950,7 +950,7 @@ static bool getCharacterPixelDimensions(FFLogoRequestData* requestData)
 {
     #ifdef _WIN32
 
-    CONSOLE_FONT_INFOEX cfi;
+    CONSOLE_FONT_INFOEX cfi = { .cbSize = sizeof(cfi) };
     if(GetCurrentConsoleFontEx(GetStdHandle(STD_OUTPUT_HANDLE), FALSE, &cfi)) // Only works for ConHost
     {
         requestData->characterPixelWidth = cfi.dwFontSize.X;