fix: code review

bennypowers · bennypowers · commit 251172ad46a2 · 2026-03-10T15:17:18.000+02:00
diff --git a/src/detection/keyboard/keyboard_linux.c b/src/detection/keyboard/keyboard_linux.c
@@ -4,15 +4,15 @@
 
 static void addDevice(FFlist* devices, uint64_t* flags, uint32_t index, FFstrbuf* path)
 {
-    if (index >= 64 || (*flags & (1UL << index)))
+    if (index >= 64 || (*flags & (1ULL << index)))
         return;
-    *flags |= (1UL << index);
 
     ffStrbufSetF(path, "/sys/class/input/event%u/device/name", (unsigned) index);
 
     FF_STRBUF_AUTO_DESTROY name = ffStrbufCreate();
     if (ffAppendFileBuffer(path->chars, &name))
     {
+        *flags |= (1ULL << index);
         ffStrbufTrimRightSpace(&name);
         ffStrbufSubstrBefore(path, path->length - (uint32_t) strlen("name"));
 

Original file line number	Diff line number	Diff line change
`@@ -4,15 +4,15 @@`
`4`	`4`
`5`	`5`	`static void addDevice(FFlist* devices, uint64_t* flags, uint32_t index, FFstrbuf* path)`
`6`	`6`	`{`
`7`		`- if (index >= 64 \|\| (*flags & (1UL << index)))`
	`7`	`+ if (index >= 64 \|\| (*flags & (1ULL << index)))`
`8`	`8`	`return;`
`9`		`- *flags \|= (1UL << index);`
`10`	`9`
`11`	`10`	`ffStrbufSetF(path, "/sys/class/input/event%u/device/name", (unsigned) index);`
`12`	`11`
`13`	`12`	`FF_STRBUF_AUTO_DESTROY name = ffStrbufCreate();`
`14`	`13`	`if (ffAppendFileBuffer(path->chars, &name))`
`15`	`14`	`{`
	`15`	`+ *flags \|= (1ULL << index);`
`16`	`16`	`ffStrbufTrimRightSpace(&name);`
`17`	`17`	`ffStrbufSubstrBefore(path, path->length - (uint32_t) strlen("name"));`
`18`	`18`