Uptime (Windows): improves comments

CarterLi · CarterLi · commit 8facb7c6e920 · 2026-03-23T16:01:29.000+08:00
diff --git a/src/common/windows/nt.h b/src/common/windows/nt.h
@@ -634,7 +634,9 @@ static inline uint64_t ffKSystemTimeToUInt64(const volatile KSYSTEM_TIME* pTime)
 {
     #if _WIN64
 
-    return *(uint64_t*) pTime;
+    // This is safe even if pTime is not 8-byte aligned
+    // See https://learn.microsoft.com/en-us/windows/win32/winprog64/fault-alignments
+    return *(const volatile uint64_t*) pTime;
 
     #else
 
diff --git a/src/detection/uptime/uptime_windows.c b/src/detection/uptime/uptime_windows.c
@@ -4,7 +4,7 @@
 
 const char* ffDetectUptime(FFUptimeResult* result)
 {
-    // GetInterruptTime with Win7 support
+    // QueryInterruptTime with Win7 support
     uint64_t interruptTime = ffKSystemTimeToUInt64(&SharedUserData->InterruptTime);
 
     result->uptime = interruptTime / 10000; // Convert from 100-nanosecond intervals to milliseconds

Original file line number	Diff line number	Diff line change
`@@ -634,7 +634,9 @@ static inline uint64_t ffKSystemTimeToUInt64(const volatile KSYSTEM_TIME* pTime)`
`634`	`634`	`{`
`635`	`635`	`#if _WIN64`
`636`	`636`
`637`		`- return (uint64_t) pTime;`
	`637`	`+ // This is safe even if pTime is not 8-byte aligned`
	`638`	`+ // See https://learn.microsoft.com/en-us/windows/win32/winprog64/fault-alignments`
	`639`	`+ return (const volatile uint64_t) pTime;`
`638`	`640`
`639`	`641`	`#else`
`640`	`642`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`
`5`	`5`	`const char* ffDetectUptime(FFUptimeResult* result)`
`6`	`6`	`{`
`7`		`- // GetInterruptTime with Win7 support`
	`7`	`+ // QueryInterruptTime with Win7 support`
`8`	`8`	`uint64_t interruptTime = ffKSystemTimeToUInt64(&SharedUserData->InterruptTime);`
`9`	`9`
`10`	`10`	`result->uptime = interruptTime / 10000; // Convert from 100-nanosecond intervals to milliseconds`