LocalIP: address Copilot suggestions

Author: jannispl

src/common/netif/netif_bsd.c

@@ -52,6 +52,9 @@ get_rt_address(struct rt_msghdr *rtm, int desired)
 
 bool ffNetifGetDefaultRouteImpl(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex, uint32_t* preferredSourceAddr)
 {
+    if (preferredSourceAddr)
+        *preferredSourceAddr = 0;
+
     #if defined(__OpenBSD__) || defined(__DragonFly__)
     int mib[6] = {CTL_NET, PF_ROUTE, 0, AF_INET, NET_RT_FLAGS, RTF_GATEWAY};
     size_t needed;

src/common/netif/netif_haiku.c

@@ -13,6 +13,9 @@
 
 bool ffNetifGetDefaultRouteImpl(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex, uint32_t* preferredSourceAddr)
 {
+    if (preferredSourceAddr)
+        *preferredSourceAddr = 0;
+
     // TODO: AF_INET6
     FF_AUTO_CLOSE_FD int pfRoute = socket(AF_INET, SOCK_RAW, AF_INET);
     if (pfRoute < 0)

src/common/netif/netif_linux.c

@@ -101,6 +101,9 @@ static bool getDefaultRouteIPv4(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex,
 
     ssize_t received = recvfrom(sock_fd, buffer, (size_t)peek_size, 0,
                                 (struct sockaddr*)&src_addr, &src_addr_len);
+    if (received != peek_size) {
+        return false;
+    }
 
     struct Route4Entry best_gw;
     memset(&best_gw, 0, sizeof(best_gw));
@@ -124,7 +127,7 @@ static bool getDefaultRouteIPv4(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex,
         entry.prefix_length = rtm->rtm_dst_len;
 
         // Parse route attributes
-        uint64_t rtm_len = RTM_PAYLOAD(nlh);
+        size_t rtm_len = RTM_PAYLOAD(nlh);
         for (struct rtattr* rta = RTM_RTA(rtm);
             RTA_OK(rta, rtm_len);
             rta = RTA_NEXT(rta, rtm_len)) {

src/common/netif/netif_windows.c

@@ -6,6 +6,9 @@
 
 bool ffNetifGetDefaultRouteImpl(char iface[IF_NAMESIZE + 1], uint32_t* ifIndex, uint32_t* preferredSourceAddr)
 {
+    if (preferredSourceAddr)
+        *preferredSourceAddr = 0;
+
     PMIB_IPFORWARD_TABLE2 pIpForwardTable = NULL;
 
     if (!NETIO_SUCCESS(GetIpForwardTable2(AF_UNSPEC, &pIpForwardTable)))