Skip to content

Commit dbb060e

Browse files
committed
Global: addresses AI's comments
1 parent 1314c18 commit dbb060e

5 files changed

Lines changed: 8 additions & 5 deletions

File tree

src/common/FFlist.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ static inline void ffListReserve(FFlist* list, uint32_t elementSize, uint32_t ne
131131
({ \
132132
typedef __typeof__(*(pCompElement)) compElementType; \
133133
typedef bool compFuncType(const compElementType*, const compElementType*); \
134-
static_assert(__builtin_types_compatible_p(__typeof__(compFunc), compFuncType), "In compatible callback function"); \
134+
static_assert(__builtin_types_compatible_p(__typeof__(compFunc), compFuncType), "Incompatible callback function"); \
135135
ffListContains(&(listVar), (uint32_t) sizeof(*(pCompElement)), (pCompElement), (bool (*)(const void*, const void*)) compFunc); \
136136
})
137137

src/common/attributes.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#pragma once
22

3-
#ifdef _MSC_VER
3+
#ifndef __has_attribute
4+
#error Unsupported compiler
45
#define __attribute__(x)
56
#endif
67

src/common/impl/debug_windows.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const char* ffDebugWin32Error(DWORD errorCode) {
1313
(DWORD) errorCode,
1414
0,
1515
bufferW,
16-
sizeof(buffer),
16+
ARRAY_SIZE(bufferW),
1717
NULL);
1818

1919
if (len == 0) {

tests/list.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55
#include <stdarg.h>
66
#include <stdlib.h>
77
#include <stdio.h>
8+
#include <stdnoreturn.h>
89

9-
__attribute__((__noreturn__)) static void testFailed(const FFlist* list, const char* expression, int lineNo) {
10+
noreturn static void testFailed(const FFlist* list, const char* expression, int lineNo) {
1011
fputs(FASTFETCH_TEXT_MODIFIER_ERROR, stderr);
1112
fprintf(stderr, "[%d] %s, list:", lineNo, expression);
1213
for (uint32_t i = 0; i < list->length; ++i) {

tests/strbuf.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@
44
#include <string.h>
55
#include <stdlib.h>
66
#include <stdio.h>
7+
#include <stdnoreturn.h>
78

8-
__attribute__((__noreturn__)) static void testFailed(const FFstrbuf* strbuf, const char* expression, int lineNo) {
9+
noreturn static void testFailed(const FFstrbuf* strbuf, const char* expression, int lineNo) {
910
fputs(FASTFETCH_TEXT_MODIFIER_ERROR, stderr);
1011
fprintf(stderr, "[%d] %s, strbuf:", lineNo, expression);
1112
ffStrbufWriteTo(strbuf, stderr);

0 commit comments

Comments
 (0)